fix: preserve version prefix in deploy.sh for helm install#92
Merged
yuanchen8911 merged 3 commits intoNVIDIA:mainfrom Feb 11, 2026
Merged
Conversation
The deploy.sh template was stripping the 'v' prefix from chart versions
via normalizeVersion(), causing Helm to log warnings like:
unable to find exact version requested; falling back to closest
available version chart=gpu-operator requested=25.10.1 selected=v25.10.1
Split the version into two fields:
- Version: original string (preserves 'v' prefix) for helm install --version
- ChartVersion: normalized string (no 'v' prefix) for chart metadata labels
Also update the test manifest template to use {{ .Chart.Version }}
matching the pattern used by real manifests in the codebase.
Signed-off-by: Yuan Chen <yuanchen97@gmail.com>
yuanchen8911
force-pushed
the
fix/preserve-version-prefix
branch
from
c26cbc9 to
2d58c7f
Compare
mchmarny
requested changes
Feb 11, 2026
Member
mchmarny
left a comment
mchmarny
left a comment
There was a problem hiding this comment.
CI doesn't check much now beyond CUJ1, so just make sure this handles the empty versions correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Helm version warning when deploy.sh strips the
vprefix from chart versions.Problem
The
normalizeVersion()function strips thevprefix from version strings for all uses, includinghelm install --version. This causes Helm to log warnings:Fix
Split version into two fields in
ComponentData:Version: Original string (preservesvprefix) — used indeploy.shforhelm install --versionChartVersion: Normalized string (novprefix) — used in manifest chart metadata labelsAlso updated the test manifest template to use
{{ .Chart.Version }}matching the pattern used by real manifests.Test plan
make testpassesTestGenerate_WithManifestspasses with correct chart label (gpu-operator-25.3.3)vprefix for--versionflag