[BENCHMAKRS] fix jet evo2 pretrain for partial conv #1115
Conversation
WalkthroughRenamed the config key artefacts_url to pckg_url in evo2_pretrain.yaml, updated its default value, and modified the pip install command to construct an authenticated index URL using pckg_url with an extra index pointing to PyPI. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant CI as CI Runner
participant SH as Shell Script
participant Pip as pip
participant GL as GitLab Package Registry
participant PYPI as PyPI
CI->>SH: Run evo2_pretrain job
SH->>Pip: pip install ${file_name_wheel} --index-url https://oauth2:$JET_GITLAB_TOKEN@${pckg_url} --extra-index-url https://pypi.org/simple/
Pip->>GL: Authenticate with oauth2 token and fetch package
alt Package not found in GitLab
Pip->>PYPI: Fallback to PyPI simple index
end
Pip-->>SH: Installation result
SH-->>CI: Job continues
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
|
/ok to test 5ff044a |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
ci/benchmarks/partial-conv/evo2_pretrain.yaml (2)
18-18: Clarify the expected format of pckg_url (host/path vs full URL).Right now the script prepends
https://oauth2:$JET_GITLAB_TOKEN@to${pckg_url}. If someone overridespckg_urlwith a value that already includeshttps://, you’ll end up with an invalid URL. Either:
- Document that
pckg_urlmust be “host/path only” (no scheme), or- Accept both by sanitizing the scheme in the script (see next comment’s diff).
Would you like me to update this with an inline comment next to
pckg_urlstating “no scheme, trailing slash required”?
10-10: Key rename correct; no danglingartefacts_urlreferences. Grep confirms onlypckg_urlis used inci/benchmarks/partial-conv/evo2_pretrain.yaml(noartefacts_urlremains). Optional: consider renaming topkg_urlorpackage_index_urlfor clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
ci/benchmarks/partial-conv/evo2_pretrain.yaml(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Analyze (rust)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1115 +/- ##
=======================================
Coverage 80.62% 80.62%
=======================================
Files 157 157
Lines 11079 11079
=======================================
Hits 8932 8932
Misses 2147 2147 |
|
/ok to test f7c8f58 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Description
Fixed installation of the subquadratic package in the command for Evo2 pretrain partial-convergence benchmarks
Type of changes
CI Pipeline Configuration
Configure CI behavior by applying the relevant labels:
Note
By default, the notebooks validation tests are skipped unless explicitly enabled.
Authorizing CI Runs
We use copy-pr-bot to manage authorization of CI
runs on NVIDIA's compute resources.
automatically be copied to a pull-request/ prefixed branch in the source repository (e.g. pull-request/123)
/ok to testcomment on the pull request to trigger CI. This will need to be done for each new commit.Usage
# TODO: Add code snippetPre-submit Checklist
Summary by CodeRabbit