review: Audit Kconfig-dependent symbol availability#17
Merged
Conversation
The portability review could miss build failures where added code references a symbol unavailable under a valid kernel configuration. This is especially easy to hide when normal build validation enables the feature providing that symbol. Extend the stage 7 and single-pass prompts to compare caller and provider preprocessor, Kconfig, architecture, Kbuild, and module conditions. Require the review to check relevant y, m, and n states against the exact checked-out tree and report prerequisites missing from the reviewed series. Keep the existing hardware checks for hardware-facing patches, but always run the configuration and linkage audit for C and Rust changes. Add prompt assertions covering disabled configurations and missing prerequisites. Signed-off-by: Andrea Righi <arighi@nvidia.com>
nirmoy
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The portability review could miss build failures where added code references a symbol unavailable under a valid kernel configuration. This is especially easy to hide when normal build validation enables the feature providing that symbol.
Extend the stage 7 and single-pass prompts to compare caller and provider preprocessor, Kconfig, architecture, Kbuild, and module conditions. Require the review to check relevant y, m, and n states against the exact checked-out tree and report prerequisites missing from the reviewed series.
Keep the existing hardware checks for hardware-facing patches, but always run the configuration and linkage audit for C and Rust changes. Add prompt assertions covering disabled configurations and missing prerequisites.