add dialect macros _CCCL_NO_RTTI and _CCCL_NO_TYPEID#2578
Merged
Conversation
Contributor
🟨 CI finished in 2h 05m: Pass: 99%/372 | Total: 2d 07h | Avg: 8m 55s | Max: 1h 21m | Hits: 10%/27873
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| pycuda | |
| CCCL C Parallel Library |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | pycuda |
| +/- | CCCL C Parallel Library |
🏃 Runner counts (total jobs: 372)
| # | Runner |
|---|---|
| 298 | linux-amd64-cpu16 |
| 31 | linux-amd64-gpu-v100-latest-1 |
| 28 | linux-arm64-cpu16 |
| 15 | windows-amd64-cpu16 |
Contributor
🟩 CI finished in 2h 44m: Pass: 100%/372 | Total: 2d 07h | Avg: 8m 52s | Max: 1h 21m | Hits: 10%/27873
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| pycuda | |
| CCCL C Parallel Library |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | pycuda |
| +/- | CCCL C Parallel Library |
🏃 Runner counts (total jobs: 372)
| # | Runner |
|---|---|
| 298 | linux-amd64-cpu16 |
| 31 | linux-amd64-gpu-v100-latest-1 |
| 28 | linux-arm64-cpu16 |
| 15 | windows-amd64-cpu16 |
miscco
reviewed
Oct 15, 2024
miscco
reviewed
Oct 15, 2024
Comment on lines
547
to
549
| # ifndef _LIBCUDACXX_NO_RTTI | ||
| # define _LIBCUDACXX_NO_RTTI | ||
| # define _LIBCUDACXX_NO_RTTI _CCCL_NO_RTTI | ||
| # endif // !_LIBCUDACXX_NO_RTTI |
Contributor
There was a problem hiding this comment.
Again, I am totally in favor of dropping libcu++ specific things in favor of global cccl macros
Contributor
Author
There was a problem hiding this comment.
i avoided making that change in this PR because it would make it harder to review. but i can make the change if you're not bothered by that.
Contributor
🟩 CI finished in 3h 16m: Pass: 100%/372 | Total: 4d 14h | Avg: 17m 45s | Max: 1h 33m | Hits: 10%/27923
|
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| pycuda | |
| CCCL C Parallel Library |
Modifications in project or dependencies?
| Project | |
|---|---|
| +/- | CCCL Infrastructure |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | pycuda |
| +/- | CCCL C Parallel Library |
🏃 Runner counts (total jobs: 372)
| # | Runner |
|---|---|
| 298 | linux-amd64-cpu16 |
| 31 | linux-amd64-gpu-v100-latest-1 |
| 28 | linux-arm64-cpu16 |
| 15 | windows-amd64-cpu16 |
miscco
approved these changes
Oct 16, 2024
pciolkosz
pushed a commit
to pciolkosz/cccl
that referenced
this pull request
Oct 25, 2024
* add dialect macros `_CCCL_NO_RTTI` and `_CCCL_NO_TYPEID` * the `typeid` operator is always available on icc in msvc-mode * replace `_LIBCUDACXX_NO_RTTI` with `_CCCL_NO_RTTI`
fbusato
pushed a commit
to fbusato/cccl
that referenced
this pull request
Nov 5, 2024
* add dialect macros `_CCCL_NO_RTTI` and `_CCCL_NO_TYPEID` * the `typeid` operator is always available on icc in msvc-mode * replace `_LIBCUDACXX_NO_RTTI` with `_CCCL_NO_RTTI`
2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There are places in the code where we need to compare types at runtime or perform
dynamic_castoperations (seememory_resource<>). Rather than jumping through hoops to avoid using RTTI, we should use it when it is available and save the hoop-jumping for when it is necessary.Checklist