[cudax] Simplify implementation of device attributes#3084
Merged
bernhardmgruber merged 1 commit intoNVIDIA:mainfrom Dec 9, 2024
Merged
[cudax] Simplify implementation of device attributes#3084bernhardmgruber merged 1 commit intoNVIDIA:mainfrom
bernhardmgruber merged 1 commit intoNVIDIA:mainfrom
Conversation
Contributor
miscco
approved these changes
Dec 9, 2024
bernhardmgruber
requested changes
Dec 9, 2024
Contributor
bernhardmgruber
left a comment
There was a problem hiding this comment.
I think this change breaks the current design. Also, since this code was merged not too long ago, @ericniebler may have had reasons for splitting __dev_attr and __dev_attr_with_type. Let's hear what he says.
Contributor
|
/ok to test |
bernhardmgruber
approved these changes
Dec 9, 2024
Contributor
bernhardmgruber
left a comment
There was a problem hiding this comment.
The change is fine, but I would still prefer to have @ericniebler's opinion on whether there was intent in splitting __dev_attr and __dev_attr_with_type.
Contributor
🟩 CI finished in 21m 16s: Pass: 100%/26 | Total: 2h 24m | Avg: 5m 33s | Max: 15m 24s | Hits: 53%/312
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
🏃 Runner counts (total jobs: 26)
| # | Runner |
|---|---|
| 18 | linux-amd64-cpu16 |
| 4 | linux-arm64-cpu16 |
| 2 | windows-amd64-cpu16 |
| 2 | linux-amd64-gpu-v100-latest-1 |
Contributor
|
Great! Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies implementation of device attributes and removes duplicate code.