Skip to content

[cudax] Simplify implementation of device attributes#3084

Merged
bernhardmgruber merged 1 commit intoNVIDIA:mainfrom
davebayer:simplify_cudax_dev_attrs
Dec 9, 2024
Merged

[cudax] Simplify implementation of device attributes#3084
bernhardmgruber merged 1 commit intoNVIDIA:mainfrom
davebayer:simplify_cudax_dev_attrs

Conversation

@davebayer
Copy link
Contributor

This PR simplifies implementation of device attributes and removes duplicate code.

@davebayer davebayer requested a review from a team as a code owner December 7, 2024 13:37
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Dec 7, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davebayer davebayer changed the title Simplify implementation of device attributes [cudax] Simplify implementation of device attributes Dec 7, 2024
Copy link
Contributor

@bernhardmgruber bernhardmgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this change breaks the current design. Also, since this code was merged not too long ago, @ericniebler may have had reasons for splitting __dev_attr and __dev_attr_with_type. Let's hear what he says.

@miscco
Copy link
Contributor

miscco commented Dec 9, 2024

/ok to test

Copy link
Contributor

@bernhardmgruber bernhardmgruber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine, but I would still prefer to have @ericniebler's opinion on whether there was intent in splitting __dev_attr and __dev_attr_with_type.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024

🟩 CI finished in 21m 16s: Pass: 100%/26 | Total: 2h 24m | Avg: 5m 33s | Max: 15m 24s | Hits: 53%/312
  • 🟩 cudax: Pass: 100%/26 | Total: 2h 24m | Avg: 5m 33s | Max: 15m 24s | Hits: 53%/312

    🟩 cpu
      🟩 amd64              Pass: 100%/22  | Total:  2h 10m | Avg:  5m 55s | Max: 15m 24s | Hits:  53%/312   
      🟩 arm64              Pass: 100%/4   | Total: 14m 23s | Avg:  3m 35s | Max:  3m 48s
    🟩 ctk
      🟩 12.0               Pass: 100%/3   | Total: 18m 21s | Avg:  6m 07s | Max: 11m 02s | Hits:  53%/156   
      🟩 12.5               Pass: 100%/2   | Total: 12m 38s | Avg:  6m 19s | Max:  6m 20s
      🟩 12.6               Pass: 100%/21  | Total:  1h 53m | Avg:  5m 24s | Max: 15m 24s | Hits:  53%/156   
    🟩 cudacxx
      🟩 nvcc12.0           Pass: 100%/3   | Total: 18m 21s | Avg:  6m 07s | Max: 11m 02s | Hits:  53%/156   
      🟩 nvcc12.5           Pass: 100%/2   | Total: 12m 38s | Avg:  6m 19s | Max:  6m 20s
      🟩 nvcc12.6           Pass: 100%/21  | Total:  1h 53m | Avg:  5m 24s | Max: 15m 24s | Hits:  53%/156   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/26  | Total:  2h 24m | Avg:  5m 33s | Max: 15m 24s | Hits:  53%/312   
    🟩 cxx
      🟩 Clang9             Pass: 100%/1   | Total:  3m 48s | Avg:  3m 48s | Max:  3m 48s
      🟩 Clang10            Pass: 100%/1   | Total:  4m 50s | Avg:  4m 50s | Max:  4m 50s
      🟩 Clang11            Pass: 100%/1   | Total:  4m 18s | Avg:  4m 18s | Max:  4m 18s
      🟩 Clang12            Pass: 100%/1   | Total:  4m 16s | Avg:  4m 16s | Max:  4m 16s
      🟩 Clang13            Pass: 100%/1   | Total:  4m 06s | Avg:  4m 06s | Max:  4m 06s
      🟩 Clang14            Pass: 100%/1   | Total:  4m 10s | Avg:  4m 10s | Max:  4m 10s
      🟩 Clang15            Pass: 100%/1   | Total:  4m 11s | Avg:  4m 11s | Max:  4m 11s
      🟩 Clang16            Pass: 100%/1   | Total:  4m 08s | Avg:  4m 08s | Max:  4m 08s
      🟩 Clang17            Pass: 100%/1   | Total:  4m 28s | Avg:  4m 28s | Max:  4m 28s
      🟩 Clang18            Pass: 100%/4   | Total: 27m 24s | Avg:  6m 51s | Max: 15m 24s
      🟩 GCC9               Pass: 100%/1   | Total:  3m 31s | Avg:  3m 31s | Max:  3m 31s
      🟩 GCC10              Pass: 100%/1   | Total:  4m 09s | Avg:  4m 09s | Max:  4m 09s
      🟩 GCC11              Pass: 100%/1   | Total:  4m 04s | Avg:  4m 04s | Max:  4m 04s
      🟩 GCC12              Pass: 100%/2   | Total: 19m 15s | Avg:  9m 37s | Max: 15m 02s
      🟩 GCC13              Pass: 100%/4   | Total: 13m 38s | Avg:  3m 24s | Max:  3m 48s
      🟩 MSVC14.36          Pass: 100%/1   | Total: 11m 02s | Avg: 11m 02s | Max: 11m 02s | Hits:  53%/156   
      🟩 MSVC14.39          Pass: 100%/1   | Total: 10m 46s | Avg: 10m 46s | Max: 10m 46s | Hits:  53%/156   
      🟩 NVHPC24.7          Pass: 100%/2   | Total: 12m 38s | Avg:  6m 19s | Max:  6m 20s
    🟩 cxx_family
      🟩 Clang              Pass: 100%/13  | Total:  1h 05m | Avg:  5m 03s | Max: 15m 24s
      🟩 GCC                Pass: 100%/9   | Total: 44m 37s | Avg:  4m 57s | Max: 15m 02s
      🟩 MSVC               Pass: 100%/2   | Total: 21m 48s | Avg: 10m 54s | Max: 11m 02s | Hits:  53%/312   
      🟩 NVHPC              Pass: 100%/2   | Total: 12m 38s | Avg:  6m 19s | Max:  6m 20s
    🟩 gpu
      🟩 v100               Pass: 100%/26  | Total:  2h 24m | Avg:  5m 33s | Max: 15m 24s | Hits:  53%/312   
    🟩 jobs
      🟩 Build              Pass: 100%/24  | Total:  1h 54m | Avg:  4m 45s | Max: 11m 02s | Hits:  53%/312   
      🟩 Test               Pass: 100%/2   | Total: 30m 26s | Avg: 15m 13s | Max: 15m 24s
    🟩 sm
      🟩 90                 Pass: 100%/1   | Total:  3m 06s | Avg:  3m 06s | Max:  3m 06s
      🟩 90a                Pass: 100%/1   | Total:  3m 17s | Avg:  3m 17s | Max:  3m 17s
    🟩 std
      🟩 17                 Pass: 100%/6   | Total: 23m 41s | Avg:  3m 56s | Max:  6m 20s
      🟩 20                 Pass: 100%/20  | Total:  2h 01m | Avg:  6m 03s | Max: 15m 24s | Hits:  53%/312   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
CUB
Thrust
+/- CUDA Experimental
python
CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 26)

# Runner
18 linux-amd64-cpu16
4 linux-arm64-cpu16
2 windows-amd64-cpu16
2 linux-amd64-gpu-v100-latest-1

Copy link
Contributor

@ericniebler ericniebler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bernhardmgruber bernhardmgruber merged commit b400516 into NVIDIA:main Dec 9, 2024
49 checks passed
@bernhardmgruber
Copy link
Contributor

Great! Thanks for the contribution!

@davebayer davebayer deleted the simplify_cudax_dev_attrs branch December 16, 2024 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants