Backport - Make compiler version comparisons safer (#4185) by wmaxey · Pull Request #4394 · NVIDIA/cccl

wmaxey · 2025-04-10T02:00:00Z

Description

Requested internally.

Checklist

New or existing tests cover these changes.
The documentation is up to date with these changes.

* Make compiler version comparisons safer * remove MSVC2017 check * use `_CCCL_HAS_CUDA_COMPILER()` instead of `_CCCL_CUDACC()`

copy-pr-bot · 2025-04-10T02:00:04Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

rwgk

Looks good to me, although I don't see any cccl/c or cccl/python changes (I don't think I'm a codeowner for anything outside those directories). Also, the mergable pre-commit check is failing?

wmaxey · 2025-04-10T06:17:15Z

There was a merge conflict, I'm still deciding if I might have messed it up.

miscco · 2025-04-10T07:17:17Z

I believe I fixed the issue

github-actions · 2025-04-10T09:28:19Z

🟩 CI finished in 2h 09m: Pass: 100%/162 | Total: 1d 13h | Avg: 13m 59s | Max: 1h 25m | Hits: 89%/252432

🟩 cub: Pass: 100%/45 | Total: 13h 59m | Avg: 18m 38s | Max: 1h 25m | Hits: 96%/53743

🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total: 13h 47m | Avg: 19m 14s | Max:  1h 25m | Hits:  96%/51301 
  🟩 arm64              Pass: 100%/2   | Total: 11m 45s | Avg:  5m 52s | Max:  6m 19s | Hits:  99%/2442  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 34m | Avg: 18m 51s | Max:  1h 09m | Hits:  95%/5936  
  🟩 12.6               Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 12m | Hits:  69%/2260  
  🟩 12.8               Pass: 100%/38  | Total: 10h 00m | Avg: 15m 47s | Max:  1h 25m | Hits:  98%/45547 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  4m 55s | Hits: 100%/2108  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 34m | Avg: 18m 51s | Max:  1h 09m | Hits:  95%/5936  
  🟩 nvcc12.6           Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 12m | Hits:  69%/2260  
  🟩 nvcc12.8           Pass: 100%/36  | Total:  9h 50m | Avg: 16m 23s | Max:  1h 25m | Hits:  98%/43439 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total:  9m 50s | Avg:  4m 55s | Max:  4m 55s | Hits: 100%/2108  
  🟩 nvcc               Pass: 100%/43  | Total: 13h 49m | Avg: 19m 17s | Max:  1h 25m | Hits:  96%/51635 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 24m 49s | Avg:  6m 12s | Max:  6m 48s | Hits: 100%/4892  
  🟩 Clang15            Pass: 100%/2   | Total: 12m 37s | Avg:  6m 18s | Max:  6m 35s | Hits: 100%/2442  
  🟩 Clang16            Pass: 100%/2   | Total: 12m 44s | Avg:  6m 22s | Max:  6m 28s | Hits: 100%/2442  
  🟩 Clang17            Pass: 100%/2   | Total: 13m 12s | Avg:  6m 36s | Max:  6m 43s | Hits: 100%/2442  
  🟩 Clang18            Pass: 100%/7   | Total:  1h 15m | Avg: 10m 46s | Max: 25m 16s | Hits: 100%/8213  
  🟩 GCC7               Pass: 100%/2   | Total: 12m 28s | Avg:  6m 14s | Max:  6m 14s | Hits:  99%/2446  
  🟩 GCC8               Pass: 100%/1   | Total:  6m 16s | Avg:  6m 16s | Max:  6m 16s | Hits:  99%/1223  
  🟩 GCC9               Pass: 100%/2   | Total: 12m 55s | Avg:  6m 27s | Max:  6m 50s | Hits:  99%/2446  
  🟩 GCC10              Pass: 100%/2   | Total: 13m 16s | Avg:  6m 38s | Max:  6m 41s | Hits:  99%/2446  
  🟩 GCC11              Pass: 100%/2   | Total: 15m 40s | Avg:  7m 50s | Max:  7m 56s | Hits:  99%/2442  
  🟩 GCC12              Pass: 100%/2   | Total: 15m 03s | Avg:  7m 31s | Max:  7m 34s | Hits:  99%/2442  
  🟩 GCC13              Pass: 100%/11  | Total:  2h 51m | Avg: 15m 32s | Max: 25m 23s | Hits:  99%/13431 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 26m | Avg:  1h 13m | Max:  1h 16m | Hits:  75%/2088  
  🟩 MSVC14.42          Pass: 100%/2   | Total:  2h 42m | Avg:  1h 21m | Max:  1h 25m | Hits:  74%/2088  
  🟩 NVHPC25.1          Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 12m | Hits:  69%/2260  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  2h 18m | Avg:  8m 09s | Max: 25m 16s | Hits: 100%/20431 
  🟩 GCC                Pass: 100%/22  | Total:  4h 06m | Avg: 11m 12s | Max: 25m 23s | Hits:  99%/26876 
  🟩 MSVC               Pass: 100%/4   | Total:  5h 09m | Avg:  1h 17m | Max:  1h 25m | Hits:  74%/4176  
  🟩 NVHPC              Pass: 100%/2   | Total:  2h 24m | Avg:  1h 12m | Max:  1h 12m | Hits:  69%/2260  
🟩 gpu
  🟩 h100               Pass: 100%/3   | Total: 50m 47s | Avg: 16m 55s | Max: 23m 50s | Hits:  99%/3663  
  🟩 rtx2080            Pass: 100%/34  | Total: 10h 35m | Avg: 18m 40s | Max:  1h 25m | Hits:  95%/40312 
  🟩 rtxa6000           Pass: 100%/8   | Total:  2h 33m | Avg: 19m 10s | Max: 25m 23s | Hits:  99%/9768  
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total: 10h 53m | Avg: 17m 39s | Max:  1h 25m | Hits:  95%/43975 
  🟩 DeviceLaunch       Pass: 100%/1   | Total: 22m 51s | Avg: 22m 51s | Max: 22m 51s | Hits:  99%/1221  
  🟩 GraphCapture       Pass: 100%/1   | Total: 20m 56s | Avg: 20m 56s | Max: 20m 56s | Hits:  99%/1221  
  🟩 HostLaunch         Pass: 100%/3   | Total:  1h 14m | Avg: 24m 49s | Max: 25m 23s | Hits:  99%/3663  
  🟩 TestGPU            Pass: 100%/3   | Total:  1h 07m | Avg: 22m 36s | Max: 23m 30s | Hits:  99%/3663  
🟩 sm
  🟩 90                 Pass: 100%/3   | Total: 50m 47s | Avg: 16m 55s | Max: 23m 50s | Hits:  99%/3663  
  🟩 90;90a;100         Pass: 100%/1   | Total:  7m 18s | Avg:  7m 18s | Max:  7m 18s | Hits:  99%/1221  
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  6h 39m | Avg: 19m 59s | Max:  1h 16m | Hits:  95%/23647 
  🟩 20                 Pass: 100%/25  | Total:  7h 19m | Avg: 17m 34s | Max:  1h 25m | Hits:  97%/30096

🟩 thrust: Pass: 100%/45 | Total: 10h 21m | Avg: 13m 48s | Max: 58m 31s | Hits: 95%/80181

🟩 cmake_options
  🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 17m 53s | Avg:  8m 56s | Max: 11m 36s | Hits:  99%/3566  
🟩 cpu
  🟩 amd64              Pass: 100%/43  | Total:  9h 47m | Avg: 13m 39s | Max: 58m 31s | Hits:  96%/76616 
  🟩 arm64              Pass: 100%/2   | Total: 33m 47s | Avg: 16m 53s | Max: 29m 14s | Hits:  89%/3565  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 14m | Avg: 14m 53s | Max: 52m 59s | Hits:  94%/8906  
  🟩 12.6               Pass: 100%/2   | Total:  1h 42m | Avg: 51m 08s | Max: 53m 14s | Hits:  73%/3564  
  🟩 12.8               Pass: 100%/38  | Total:  7h 24m | Avg: 11m 42s | Max: 58m 31s | Hits:  97%/67711 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 10m 07s | Avg:  5m 03s | Max:  5m 05s | Hits: 100%/3564  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 14m | Avg: 14m 53s | Max: 52m 59s | Hits:  94%/8906  
  🟩 nvcc12.6           Pass: 100%/2   | Total:  1h 42m | Avg: 51m 08s | Max: 53m 14s | Hits:  73%/3564  
  🟩 nvcc12.8           Pass: 100%/36  | Total:  7h 14m | Avg: 12m 04s | Max: 58m 31s | Hits:  97%/64147 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 10m 07s | Avg:  5m 03s | Max:  5m 05s | Hits: 100%/3564  
  🟩 nvcc               Pass: 100%/43  | Total: 10h 11m | Avg: 14m 12s | Max: 58m 31s | Hits:  95%/76617 
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 21m 56s | Avg:  5m 29s | Max:  6m 02s | Hits: 100%/7128  
  🟩 Clang15            Pass: 100%/2   | Total: 11m 47s | Avg:  5m 53s | Max:  6m 01s | Hits: 100%/3564  
  🟩 Clang16            Pass: 100%/2   | Total: 11m 11s | Avg:  5m 35s | Max:  5m 45s | Hits: 100%/3564  
  🟩 Clang17            Pass: 100%/2   | Total: 11m 27s | Avg:  5m 43s | Max:  5m 53s | Hits: 100%/3564  
  🟩 Clang18            Pass: 100%/7   | Total: 43m 17s | Avg:  6m 11s | Max: 10m 23s | Hits: 100%/12474 
  🟩 GCC7               Pass: 100%/2   | Total: 11m 12s | Avg:  5m 36s | Max:  5m 53s | Hits:  99%/3566  
  🟩 GCC8               Pass: 100%/1   | Total:  5m 40s | Avg:  5m 40s | Max:  5m 40s | Hits:  99%/1783  
  🟩 GCC9               Pass: 100%/2   | Total: 10m 48s | Avg:  5m 24s | Max:  5m 44s | Hits:  99%/3566  
  🟩 GCC10              Pass: 100%/2   | Total: 11m 38s | Avg:  5m 49s | Max:  5m 52s | Hits:  99%/3566  
  🟩 GCC11              Pass: 100%/2   | Total: 12m 08s | Avg:  6m 04s | Max:  6m 17s | Hits:  99%/3566  
  🟩 GCC12              Pass: 100%/2   | Total: 12m 43s | Avg:  6m 21s | Max:  6m 45s | Hits:  99%/3566  
  🟩 GCC13              Pass: 100%/10  | Total:  1h 43m | Avg: 10m 18s | Max: 29m 14s | Hits:  97%/17830 
  🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 51m | Avg: 55m 39s | Max: 58m 20s | Hits:  73%/3552  
  🟩 MSVC14.42          Pass: 100%/3   | Total:  2h 20m | Avg: 46m 58s | Max: 58m 31s | Hits:  82%/5328  
  🟩 NVHPC25.1          Pass: 100%/2   | Total:  1h 42m | Avg: 51m 08s | Max: 53m 14s | Hits:  73%/3564  
🟩 cxx_family
  🟩 Clang              Pass: 100%/17  | Total:  1h 39m | Avg:  5m 51s | Max: 10m 23s | Hits: 100%/30294 
  🟩 GCC                Pass: 100%/21  | Total:  2h 47m | Avg:  7m 57s | Max: 29m 14s | Hits:  98%/37443 
  🟩 MSVC               Pass: 100%/5   | Total:  4h 12m | Avg: 50m 26s | Max: 58m 31s | Hits:  78%/8880  
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 42m | Avg: 51m 08s | Max: 53m 14s | Hits:  73%/3564  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 16m 29s | Avg:  8m 14s | Max: 11m 13s | Hits:  99%/3566  
  🟩 rtx2080            Pass: 100%/33  | Total:  7h 31m | Avg: 13m 40s | Max: 58m 20s | Hits:  95%/58802 
  🟩 rtx4090            Pass: 100%/10  | Total:  2h 33m | Avg: 15m 21s | Max: 58m 31s | Hits:  97%/17813 
🟩 jobs
  🟩 Build              Pass: 100%/38  | Total:  8h 52m | Avg: 14m 01s | Max: 58m 31s | Hits:  95%/67709 
  🟩 TestCPU            Pass: 100%/3   | Total: 43m 23s | Avg: 14m 27s | Max: 27m 02s | Hits:  99%/5341  
  🟩 TestGPU            Pass: 100%/4   | Total: 45m 06s | Avg: 11m 16s | Max: 11m 54s | Hits:  99%/7131  
🟩 sm
  🟩 90                 Pass: 100%/2   | Total: 16m 29s | Avg:  8m 14s | Max: 11m 13s | Hits:  99%/3566  
  🟩 90;90a;100         Pass: 100%/1   | Total:  6m 10s | Avg:  6m 10s | Max:  6m 10s | Hits:  99%/1783  
🟩 std
  🟩 17                 Pass: 100%/20  | Total:  5h 10m | Avg: 15m 31s | Max: 58m 20s | Hits:  94%/35631 
  🟩 20                 Pass: 100%/23  | Total:  4h 52m | Avg: 12m 44s | Max: 58m 31s | Hits:  96%/40984

🟩 libcudacxx: Pass: 100%/43 | Total: 9h 26m | Avg: 13m 10s | Max: 36m 13s | Hits: 80%/106358

🟩 cpu
  🟩 amd64              Pass: 100%/41  | Total:  9h 13m | Avg: 13m 30s | Max: 36m 13s | Hits:  79%/100541
  🟩 arm64              Pass: 100%/2   | Total: 12m 59s | Avg:  6m 29s | Max:  7m 08s | Hits:  90%/5817  
🟩 ctk
  🟩 12.0               Pass: 100%/5   | Total:  1h 00m | Avg: 12m 11s | Max: 25m 12s | Hits:  85%/14170 
  🟩 12.6               Pass: 100%/2   | Total:  1h 10m | Avg: 35m 07s | Max: 36m 13s | Hits:  29%/5764  
  🟩 12.8               Pass: 100%/36  | Total:  7h 15m | Avg: 12m 06s | Max: 28m 53s | Hits:  82%/86424 
🟩 cudacxx
  🟩 ClangCUDA18        Pass: 100%/2   | Total: 47m 56s | Avg: 23m 58s | Max: 24m 52s | Hits:  27%/5778  
  🟩 nvcc12.0           Pass: 100%/5   | Total:  1h 00m | Avg: 12m 11s | Max: 25m 12s | Hits:  85%/14170 
  🟩 nvcc12.6           Pass: 100%/2   | Total:  1h 10m | Avg: 35m 07s | Max: 36m 13s | Hits:  29%/5764  
  🟩 nvcc12.8           Pass: 100%/34  | Total:  6h 27m | Avg: 11m 24s | Max: 28m 53s | Hits:  86%/80646 
🟩 cudacxx_family
  🟩 ClangCUDA          Pass: 100%/2   | Total: 47m 56s | Avg: 23m 58s | Max: 24m 52s | Hits:  27%/5778  
  🟩 nvcc               Pass: 100%/41  | Total:  8h 38m | Avg: 12m 39s | Max: 36m 13s | Hits:  83%/100580
🟩 cxx
  🟩 Clang14            Pass: 100%/4   | Total: 36m 15s | Avg:  9m 03s | Max: 11m 51s | Hits:  86%/11524 
  🟩 Clang15            Pass: 100%/2   | Total: 12m 33s | Avg:  6m 16s | Max:  7m 59s | Hits:  94%/5774  
  🟩 Clang16            Pass: 100%/2   | Total: 18m 25s | Avg:  9m 12s | Max:  9m 21s | Hits:  87%/5774  
  🟩 Clang17            Pass: 100%/2   | Total: 17m 15s | Avg:  8m 37s | Max:  9m 14s | Hits:  88%/5774  
  🟩 Clang18            Pass: 100%/6   | Total:  1h 29m | Avg: 14m 54s | Max: 24m 52s | Hits:  65%/14460 
  🟩 GCC7               Pass: 100%/2   | Total: 14m 04s | Avg:  7m 02s | Max:  7m 24s | Hits:  88%/5712  
  🟩 GCC8               Pass: 100%/1   | Total:  8m 30s | Avg:  8m 30s | Max:  8m 30s | Hits:  85%/2866  
  🟩 GCC9               Pass: 100%/2   | Total: 17m 37s | Avg:  8m 48s | Max:  8m 56s | Hits:  87%/5724  
  🟩 GCC10              Pass: 100%/2   | Total: 15m 23s | Avg:  7m 41s | Max:  7m 51s | Hits:  88%/5780  
  🟩 GCC11              Pass: 100%/2   | Total: 12m 56s | Avg:  6m 28s | Max:  8m 37s | Hits:  92%/5776  
  🟩 GCC12              Pass: 100%/2   | Total: 30m 00s | Avg: 15m 00s | Max: 22m 32s | Hits:  69%/5776  
  🟩 GCC13              Pass: 100%/10  | Total:  1h 57m | Avg: 11m 42s | Max: 23m 40s | Hits:  81%/14721 
  🟩 MSVC14.29          Pass: 100%/2   | Total: 51m 26s | Avg: 25m 43s | Max: 26m 14s | Hits:  87%/5432  
  🟩 MSVC14.42          Pass: 100%/2   | Total: 55m 38s | Avg: 27m 49s | Max: 28m 53s | Hits:  87%/5501  
  🟩 NVHPC25.1          Pass: 100%/2   | Total:  1h 10m | Avg: 35m 07s | Max: 36m 13s | Hits:  29%/5764  
🟩 cxx_family
  🟩 Clang              Pass: 100%/16  | Total:  2h 53m | Avg: 10m 52s | Max: 24m 52s | Hits:  80%/43306 
  🟩 GCC                Pass: 100%/21  | Total:  3h 35m | Avg: 10m 15s | Max: 23m 40s | Hits:  84%/46355 
  🟩 MSVC               Pass: 100%/4   | Total:  1h 47m | Avg: 26m 46s | Max: 28m 53s | Hits:  87%/10933 
  🟩 NVHPC              Pass: 100%/2   | Total:  1h 10m | Avg: 35m 07s | Max: 36m 13s | Hits:  29%/5764  
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 17m 58s | Avg:  8m 59s | Max: 13m 29s | Hits:  99%/2998  
  🟩 rtx2080            Pass: 100%/41  | Total:  9h 08m | Avg: 13m 23s | Max: 36m 13s | Hits:  79%/103360
🟩 jobs
  🟩 Build              Pass: 100%/37  | Total:  7h 58m | Avg: 12m 56s | Max: 36m 13s | Hits:  80%/106318
  🟩 NVRTC              Pass: 100%/2   | Total: 36m 08s | Avg: 18m 04s | Max: 20m 31s | Hits:  90%/40    
  🟩 Test               Pass: 100%/3   | Total: 49m 56s | Avg: 16m 38s | Max: 18m 28s
  🟩 VerifyCodegen      Pass: 100%/1   | Total:  2m 08s | Avg:  2m 08s | Max:  2m 08s
🟩 sm
  🟩 75                 Pass: 100%/2   | Total: 36m 08s | Avg: 18m 04s | Max: 20m 31s | Hits:  90%/40    
  🟩 90                 Pass: 100%/2   | Total: 17m 58s | Avg:  8m 59s | Max: 13m 29s | Hits:  99%/2998  
  🟩 90;90a;100         Pass: 100%/1   | Total:  7m 41s | Avg:  7m 41s | Max:  7m 41s | Hits:  89%/2998  
🟩 std
  🟩 17                 Pass: 100%/21  | Total:  4h 49m | Avg: 13m 46s | Max: 34m 02s | Hits:  79%/56859 
  🟩 20                 Pass: 100%/21  | Total:  4h 35m | Avg: 13m 06s | Max: 36m 13s | Hits:  80%/49499

🟩 cudax: Pass: 100%/22 | Total: 2h 11m | Avg: 5m 57s | Max: 14m 25s | Hits: 98%/11830

🟩 cpu
  🟩 amd64              Pass: 100%/18  | Total:  1h 59m | Avg:  6m 38s | Max: 14m 25s | Hits:  98%/9494  
  🟩 arm64              Pass: 100%/4   | Total: 11m 29s | Avg:  2m 52s | Max:  2m 57s | Hits:  99%/2336  
🟩 ctk
  🟩 12.0               Pass: 100%/1   | Total: 13m 45s | Avg: 13m 45s | Max: 13m 45s | Hits:  87%/281   
  🟩 12.6               Pass: 100%/2   | Total: 15m 02s | Avg:  7m 31s | Max:  7m 33s | Hits:  90%/752   
  🟩 12.8               Pass: 100%/19  | Total:  1h 42m | Avg:  5m 23s | Max: 14m 25s | Hits:  99%/10797 
🟩 cudacxx
  🟩 nvcc12.0           Pass: 100%/1   | Total: 13m 45s | Avg: 13m 45s | Max: 13m 45s | Hits:  87%/281   
  🟩 nvcc12.6           Pass: 100%/2   | Total: 15m 02s | Avg:  7m 31s | Max:  7m 33s | Hits:  90%/752   
  🟩 nvcc12.8           Pass: 100%/19  | Total:  1h 42m | Avg:  5m 23s | Max: 14m 25s | Hits:  99%/10797 
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/22  | Total:  2h 11m | Avg:  5m 57s | Max: 14m 25s | Hits:  98%/11830 
🟩 cxx
  🟩 Clang14            Pass: 100%/1   | Total:  3m 23s | Avg:  3m 23s | Max:  3m 23s | Hits: 100%/586   
  🟩 Clang15            Pass: 100%/1   | Total:  3m 38s | Avg:  3m 38s | Max:  3m 38s | Hits: 100%/584   
  🟩 Clang16            Pass: 100%/1   | Total:  3m 25s | Avg:  3m 25s | Max:  3m 25s | Hits: 100%/584   
  🟩 Clang17            Pass: 100%/1   | Total:  3m 29s | Avg:  3m 29s | Max:  3m 29s | Hits: 100%/584   
  🟩 Clang18            Pass: 100%/4   | Total: 21m 29s | Avg:  5m 22s | Max: 12m 29s | Hits: 100%/2336  
  🟩 GCC10              Pass: 100%/1   | Total:  3m 29s | Avg:  3m 29s | Max:  3m 29s | Hits:  99%/586   
  🟩 GCC11              Pass: 100%/1   | Total:  3m 16s | Avg:  3m 16s | Max:  3m 16s | Hits:  99%/584   
  🟩 GCC12              Pass: 100%/2   | Total: 16m 57s | Avg:  8m 28s | Max: 12m 56s | Hits:  99%/1168  
  🟩 GCC13              Pass: 100%/6   | Total: 29m 32s | Avg:  4m 55s | Max: 14m 25s | Hits:  99%/3504  
  🟩 MSVC14.39          Pass: 100%/1   | Total: 13m 45s | Avg: 13m 45s | Max: 13m 45s | Hits:  87%/281   
  🟩 MSVC14.42          Pass: 100%/1   | Total: 13m 43s | Avg: 13m 43s | Max: 13m 43s | Hits:  87%/281   
  🟩 NVHPC25.1          Pass: 100%/2   | Total: 15m 02s | Avg:  7m 31s | Max:  7m 33s | Hits:  90%/752   
🟩 cxx_family
  🟩 Clang              Pass: 100%/8   | Total: 35m 24s | Avg:  4m 25s | Max: 12m 29s | Hits: 100%/4674  
  🟩 GCC                Pass: 100%/10  | Total: 53m 14s | Avg:  5m 19s | Max: 14m 25s | Hits:  99%/5842  
  🟩 MSVC               Pass: 100%/2   | Total: 27m 28s | Avg: 13m 44s | Max: 13m 45s | Hits:  87%/562   
  🟩 NVHPC              Pass: 100%/2   | Total: 15m 02s | Avg:  7m 31s | Max:  7m 33s | Hits:  90%/752   
🟩 gpu
  🟩 h100               Pass: 100%/2   | Total: 17m 34s | Avg:  8m 47s | Max: 14m 25s | Hits:  99%/1168  
  🟩 rtx2080            Pass: 100%/20  | Total:  1h 53m | Avg:  5m 40s | Max: 13m 45s | Hits:  98%/10662 
🟩 jobs
  🟩 Build              Pass: 100%/19  | Total:  1h 31m | Avg:  4m 48s | Max: 13m 45s | Hits:  98%/10078 
  🟩 Test               Pass: 100%/3   | Total: 39m 50s | Avg: 13m 16s | Max: 14m 25s | Hits:  99%/1752  
🟩 sm
  🟩 90                 Pass: 100%/3   | Total: 20m 35s | Avg:  6m 51s | Max: 14m 25s | Hits:  99%/1752  
  🟩 90a                Pass: 100%/1   | Total:  3m 06s | Avg:  3m 06s | Max:  3m 06s | Hits:  99%/584   
🟩 std
  🟩 17                 Pass: 100%/4   | Total: 16m 13s | Avg:  4m 03s | Max:  7m 29s | Hits:  98%/2128  
  🟩 20                 Pass: 100%/18  | Total:  1h 54m | Avg:  6m 23s | Max: 14m 25s | Hits:  98%/9702

🟩 stdpar: Pass: 100%/4 | Total: 20m 02s | Avg: 5m 00s | Max: 5m 42s

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 10m 14s | Avg:  5m 07s | Max:  5m 10s
  🟩 arm64              Pass: 100%/2   | Total:  9m 48s | Avg:  4m 54s | Max:  5m 42s
🟩 ctk
  🟩 12.6               Pass: 100%/4   | Total: 20m 02s | Avg:  5m 00s | Max:  5m 42s
🟩 cudacxx
  🟩 nvcc12.6           Pass: 100%/4   | Total: 20m 02s | Avg:  5m 00s | Max:  5m 42s
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/4   | Total: 20m 02s | Avg:  5m 00s | Max:  5m 42s
🟩 cxx
  🟩 NVHPC25.1          Pass: 100%/4   | Total: 20m 02s | Avg:  5m 00s | Max:  5m 42s
🟩 cxx_family
  🟩 NVHPC              Pass: 100%/4   | Total: 20m 02s | Avg:  5m 00s | Max:  5m 42s
🟩 gpu
  🟩 rtx2080            Pass: 100%/4   | Total: 20m 02s | Avg:  5m 00s | Max:  5m 42s
🟩 jobs
  🟩 Build              Pass: 100%/4   | Total: 20m 02s | Avg:  5m 00s | Max:  5m 42s
🟩 std
  🟩 17                 Pass: 100%/2   | Total: 10m 52s | Avg:  5m 26s | Max:  5m 42s
  🟩 20                 Pass: 100%/2   | Total:  9m 10s | Avg:  4m 35s | Max:  5m 04s

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 17m 32s | Avg: 8m 46s | Max: 15m 10s | Hits: 98%/320

🟩 cpu
  🟩 amd64              Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 15m 10s | Hits:  98%/320   
🟩 ctk
  🟩 12.8               Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 15m 10s | Hits:  98%/320   
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 15m 10s | Hits:  98%/320   
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 15m 10s | Hits:  98%/320   
🟩 cxx
  🟩 GCC13              Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 15m 10s | Hits:  98%/320   
🟩 cxx_family
  🟩 GCC                Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 15m 10s | Hits:  98%/320   
🟩 gpu
  🟩 rtx2080            Pass: 100%/2   | Total: 17m 32s | Avg:  8m 46s | Max: 15m 10s | Hits:  98%/320   
🟩 jobs
  🟩 Build              Pass: 100%/1   | Total:  2m 22s | Avg:  2m 22s | Max:  2m 22s | Hits:  98%/160   
  🟩 Test               Pass: 100%/1   | Total: 15m 10s | Avg: 15m 10s | Max: 15m 10s | Hits:  98%/160

🟩 python: Pass: 100%/1 | Total: 1h 09m | Avg: 1h 09m | Max: 1h 09m

🟩 cpu
  🟩 amd64              Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m
🟩 ctk
  🟩 12.8               Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m
🟩 cudacxx
  🟩 nvcc12.8           Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m
🟩 cudacxx_family
  🟩 nvcc               Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m
🟩 cxx
  🟩 GCC13              Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m
🟩 cxx_family
  🟩 GCC                Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m
🟩 gpu
  🟩 rtx2080            Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m
🟩 jobs
  🟩 Test               Pass: 100%/1   | Total:  1h 09m | Avg:  1h 09m | Max:  1h 09m

👃 Inspect Changes

Modifications in project?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
	stdpar
	python
	CCCL C Parallel Library
	Catch2Helper

Modifications in project or dependencies?

	Project
	CCCL Infrastructure
+/-	libcu++
+/-	CUB
+/-	Thrust
+/-	CUDA Experimental
+/-	stdpar
+/-	python
+/-	CCCL C Parallel Library
+/-	Catch2Helper

🏃‍ Runner counts (total jobs: 162)

#	Runner
113	`linux-amd64-cpu16`
15	`windows-amd64-cpu16`
12	`linux-arm64-cpu16`
8	`linux-amd64-gpu-rtx2080-latest-1`
6	`linux-amd64-gpu-rtxa6000-latest-1`
5	`linux-amd64-gpu-h100-latest-1`
3	`linux-amd64-gpu-rtx4090-latest-1`

Make compiler version comparisons safer (#4185)

c518f22

* Make compiler version comparisons safer * remove MSVC2017 check * use `_CCCL_HAS_CUDA_COMPILER()` instead of `_CCCL_CUDACC()`

wmaxey requested review from a team as code owners April 10, 2025 02:00

wmaxey requested a review from elstehle April 10, 2025 02:00

github-project-automation Bot added this to CCCL Apr 10, 2025

github-project-automation Bot moved this to Todo in CCCL Apr 10, 2025

wmaxey requested review from miscco and rwgk April 10, 2025 02:00

cccl-authenticator-app Bot moved this from Todo to In Review in CCCL Apr 10, 2025

wmaxey changed the base branch from main to branch/3.0.x April 10, 2025 02:01

wmaxey changed the title ~~Backport/pr 4185~~ Backport - Make compiler version comparisons safer (#4185) Apr 10, 2025

rwgk approved these changes Apr 10, 2025

View reviewed changes

Fix compile issues

956528e

miscco approved these changes Apr 10, 2025

View reviewed changes

miscco enabled auto-merge (squash) April 10, 2025 08:56

bernhardmgruber approved these changes Apr 10, 2025

View reviewed changes

miscco merged commit c1cfc70 into branch/3.0.x Apr 10, 2025
177 of 178 checks passed

github-project-automation Bot moved this from In Review to Done in CCCL Apr 10, 2025

miscco deleted the backport/pr_4185 branch April 10, 2025 09:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport - Make compiler version comparisons safer (#4185)#4394

Backport - Make compiler version comparisons safer (#4185)#4394
miscco merged 2 commits intobranch/3.0.xfrom
backport/pr_4185

wmaxey commented Apr 10, 2025

Uh oh!

copy-pr-bot Bot commented Apr 10, 2025

Uh oh!

rwgk left a comment

Uh oh!

wmaxey commented Apr 10, 2025

Uh oh!

miscco commented Apr 10, 2025

Uh oh!

github-actions Bot commented Apr 10, 2025

🟩 cub: Pass: 100%/45 | Total: 13h 59m | Avg: 18m 38s | Max: 1h 25m | Hits: 96%/53743

🟩 thrust: Pass: 100%/45 | Total: 10h 21m | Avg: 13m 48s | Max: 58m 31s | Hits: 95%/80181

🟩 libcudacxx: Pass: 100%/43 | Total: 9h 26m | Avg: 13m 10s | Max: 36m 13s | Hits: 80%/106358

🟩 cudax: Pass: 100%/22 | Total: 2h 11m | Avg: 5m 57s | Max: 14m 25s | Hits: 98%/11830

🟩 stdpar: Pass: 100%/4 | Total: 20m 02s | Avg: 5m 00s | Max: 5m 42s

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 17m 32s | Avg: 8m 46s | Max: 15m 10s | Hits: 98%/320

🟩 python: Pass: 100%/1 | Total: 1h 09m | Avg: 1h 09m | Max: 1h 09m

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 162)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

wmaxey commented Apr 10, 2025

Description

Checklist

Uh oh!

copy-pr-bot Bot commented Apr 10, 2025

Uh oh!

rwgk left a comment

Choose a reason for hiding this comment

Uh oh!

wmaxey commented Apr 10, 2025

Uh oh!

miscco commented Apr 10, 2025

Uh oh!

github-actions Bot commented Apr 10, 2025

🟩 cub: Pass: 100%/45 | Total: 13h 59m | Avg: 18m 38s | Max: 1h 25m | Hits: 96%/53743

🟩 thrust: Pass: 100%/45 | Total: 10h 21m | Avg: 13m 48s | Max: 58m 31s | Hits: 95%/80181

🟩 libcudacxx: Pass: 100%/43 | Total: 9h 26m | Avg: 13m 10s | Max: 36m 13s | Hits: 80%/106358

🟩 cudax: Pass: 100%/22 | Total: 2h 11m | Avg: 5m 57s | Max: 14m 25s | Hits: 98%/11830

🟩 stdpar: Pass: 100%/4 | Total: 20m 02s | Avg: 5m 00s | Max: 5m 42s

🟩 cccl_c_parallel: Pass: 100%/2 | Total: 17m 32s | Avg: 8m 46s | Max: 15m 10s | Hits: 98%/320

🟩 python: Pass: 100%/1 | Total: 1h 09m | Avg: 1h 09m | Max: 1h 09m

👃 Inspect Changes

Modifications in project?

Modifications in project or dependencies?

🏃‍ Runner counts (total jobs: 162)

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants