[Backport branch/3.0.x] Fix uninitialized read in local atomic code path.#4425
Merged
wmaxey merged 1 commit intobranch/3.0.xfrom Apr 12, 2025
Merged
[Backport branch/3.0.x] Fix uninitialized read in local atomic code path.#4425wmaxey merged 1 commit intobranch/3.0.xfrom
wmaxey merged 1 commit intobranch/3.0.xfrom
Conversation
* Fix uninitialized read in local atomic code path. * PTX assumes '=' operands are always overwritten. For this code path the predicated mov instruction will only sometimes overwrite the original value. The compiler may or may not initialize `__temp`. This patch fixes this by always signing a 0 or 1 to the output register removing the need to initialize `__temp`. An alternative is to use `+` instead of `=` on the output operand. * Create a test to cover the PTX path of local storage atomics regardless of CTK version * Disable test for nvrtc * Use new additional compile flags * Try and fix checking for compile flags * Update comments in is_local codepath * Make test compatible with older NVCC * Revert "Try and fix checking for compile flags" This reverts commit a846ea5. * Remove unroll pragma, it is unneeded for repro. --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> (cherry picked from commit 3200156)
2 tasks
Contributor
wmaxey
approved these changes
Apr 12, 2025
Member
|
/ok to test 97bf5ec |
Contributor
Author
🟩 CI finished in 11h 06m: Pass: 100%/162 | Total: 1d 16h | Avg: 15m 05s | Max: 1h 16m | Hits: 91%/252465
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 162)
| # | Runner |
|---|---|
| 113 | linux-amd64-cpu16 |
| 15 | windows-amd64-cpu16 |
| 12 | linux-arm64-cpu16 |
| 8 | linux-amd64-gpu-rtx2080-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 5 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #4352 to
branch/3.0.x.