[Backport] Add stream__wrapper test to thrust#4492
Merged
miscco merged 3 commits intoNVIDIA:branch/3.0.xfrom Apr 22, 2025
Merged
[Backport] Add stream__wrapper test to thrust#4492miscco merged 3 commits intoNVIDIA:branch/3.0.xfrom
miscco merged 3 commits intoNVIDIA:branch/3.0.xfrom
Conversation
* Use `cudaStream_t` for `thrust::device.on(...)`. This was recently switched to use `cuda::stream_ref`, which broke users that have their own custom stream wrappers (nvbench, rmm, probably others). There's no real benefit to using a stream_ref here, and it breaks existing implicit conversions. * Add test to ensure that stream wrappers work with thrust::device.on
Contributor
bernhardmgruber
approved these changes
Apr 20, 2025
miscco
approved these changes
Apr 22, 2025
Contributor
🟩 CI finished in 1h 35m: Pass: 100%/97 | Total: 18h 41m | Avg: 11m 33s | Max: 1h 13m | Hits: 98%/134408
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 97)
| # | Runner |
|---|---|
| 68 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
Contributor
🟩 CI finished in 1h 33m: Pass: 100%/97 | Total: 16h 39m | Avg: 10m 18s | Max: 1h 11m | Hits: 99%/134408
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| CUB | |
| +/- | Thrust |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| libcu++ | |
| +/- | CUB |
| +/- | Thrust |
| CUDA Experimental | |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 97)
| # | Runner |
|---|---|
| 68 | linux-amd64-cpu16 |
| 9 | windows-amd64-cpu16 |
| 6 | linux-arm64-cpu16 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-h100-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
| 2 | linux-amd64-gpu-rtx2080-latest-1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add test to ensure that stream wrappers work with thrust::device.on.