Skip to content

Ignore Wmaybe-uninitialized in dispatch_reduce.cuh.#4622

Merged
alliepiper merged 1 commit intoNVIDIA:branch/3.0.xfrom
bdice:pragma-ignore-maybe-uninitialized-2
May 7, 2025
Merged

Ignore Wmaybe-uninitialized in dispatch_reduce.cuh.#4622
alliepiper merged 1 commit intoNVIDIA:branch/3.0.xfrom
bdice:pragma-ignore-maybe-uninitialized-2

Conversation

@bdice
Copy link
Copy Markdown
Contributor

@bdice bdice commented May 2, 2025

Description

This forward-ports #4054 to branch/3.0.x.

I am seeing #4053 -Wmaybe-uninitialized in dispatch_reduce.cuh again. From my testing, the changes in #4054 are also needed in CCCL 3.0.x but not in main. I targeted branch/3.0.x for this reason.

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@github-project-automation github-project-automation Bot moved this to Todo in CCCL May 2, 2025
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Progress in CCCL May 2, 2025
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented May 2, 2025

/ok to test

@NVIDIA NVIDIA deleted a comment from copy-pr-bot Bot May 2, 2025
@bdice bdice marked this pull request as ready for review May 2, 2025 14:23
@bdice bdice requested a review from a team as a code owner May 2, 2025 14:23
@bdice bdice requested a review from gevtushenko May 2, 2025 14:23
@cccl-authenticator-app cccl-authenticator-app Bot moved this from In Progress to In Review in CCCL May 2, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2025

🟩 CI finished in 1h 35m: Pass: 100%/97 | Total: 2d 19h | Avg: 41m 46s | Max: 1h 25m | Hits: 78%/134408
  • 🟩 cub: Pass: 100%/45 | Total: 1d 19h | Avg: 57m 32s | Max: 1h 25m | Hits: 73%/53817

    🟩 cpu
      🟩 amd64              Pass: 100%/43  | Total:  1d 17h | Avg: 57m 16s | Max:  1h 25m | Hits:  74%/51371 
      🟩 arm64              Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 03m | Hits:  66%/2446  
    🟩 ctk
      🟩 12.0               Pass: 100%/5   | Total:  5h 20m | Avg:  1h 04m | Max:  1h 08m | Hits:  68%/5944  
      🟩 12.6               Pass: 100%/2   | Total:  2h 35m | Avg:  1h 17m | Max:  1h 24m | Hits:  67%/2260  
      🟩 12.8               Pass: 100%/38  | Total:  1d 11h | Avg: 55m 36s | Max:  1h 25m | Hits:  74%/45613 
    🟩 cudacxx
      🟩 ClangCUDA18        Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 01m | Hits:  73%/2108  
      🟩 nvcc12.0           Pass: 100%/5   | Total:  5h 20m | Avg:  1h 04m | Max:  1h 08m | Hits:  68%/5944  
      🟩 nvcc12.6           Pass: 100%/2   | Total:  2h 35m | Avg:  1h 17m | Max:  1h 24m | Hits:  67%/2260  
      🟩 nvcc12.8           Pass: 100%/36  | Total:  1d 09h | Avg: 55m 16s | Max:  1h 25m | Hits:  75%/43505 
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total:  2h 02m | Avg:  1h 01m | Max:  1h 01m | Hits:  73%/2108  
      🟩 nvcc               Pass: 100%/43  | Total:  1d 17h | Avg: 57m 21s | Max:  1h 25m | Hits:  73%/51709 
    🟩 cxx
      🟩 Clang14            Pass: 100%/4   | Total:  4h 08m | Avg:  1h 02m | Max:  1h 04m | Hits:  67%/4900  
      🟩 Clang15            Pass: 100%/2   | Total:  2h 07m | Avg:  1h 03m | Max:  1h 06m | Hits:  67%/2446  
      🟩 Clang16            Pass: 100%/2   | Total:  2h 11m | Avg:  1h 05m | Max:  1h 06m | Hits:  67%/2446  
      🟩 Clang17            Pass: 100%/2   | Total:  2h 09m | Avg:  1h 04m | Max:  1h 08m | Hits:  67%/2446  
      🟩 Clang18            Pass: 100%/7   | Total:  5h 49m | Avg: 49m 51s | Max:  1h 03m | Hits:  78%/8223  
      🟩 GCC7               Pass: 100%/2   | Total:  2h 12m | Avg:  1h 06m | Max:  1h 06m | Hits:  67%/2450  
      🟩 GCC8               Pass: 100%/1   | Total:  1h 02m | Avg:  1h 02m | Max:  1h 02m | Hits:  67%/1225  
      🟩 GCC9               Pass: 100%/2   | Total:  2h 06m | Avg:  1h 03m | Max:  1h 03m | Hits:  67%/2450  
      🟩 GCC10              Pass: 100%/2   | Total:  2h 04m | Avg:  1h 02m | Max:  1h 03m | Hits:  67%/2450  
      🟩 GCC11              Pass: 100%/2   | Total:  2h 13m | Avg:  1h 06m | Max:  1h 07m | Hits:  67%/2446  
      🟩 GCC12              Pass: 100%/2   | Total:  2h 04m | Avg:  1h 02m | Max:  1h 03m | Hits:  67%/2446  
      🟩 GCC13              Pass: 100%/11  | Total:  7h 10m | Avg: 39m 08s | Max:  1h 14m | Hits:  84%/13453 
      🟩 MSVC14.29          Pass: 100%/2   | Total:  2h 25m | Avg:  1h 12m | Max:  1h 17m | Hits:  72%/2088  
      🟩 MSVC14.42          Pass: 100%/2   | Total:  2h 45m | Avg:  1h 22m | Max:  1h 25m | Hits:  72%/2088  
      🟩 NVHPC25.1          Pass: 100%/2   | Total:  2h 35m | Avg:  1h 17m | Max:  1h 24m | Hits:  67%/2260  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/17  | Total: 16h 27m | Avg: 58m 05s | Max:  1h 08m | Hits:  71%/20461 
      🟩 GCC                Pass: 100%/22  | Total: 18h 54m | Avg: 51m 34s | Max:  1h 14m | Hits:  76%/26920 
      🟩 MSVC               Pass: 100%/4   | Total:  5h 11m | Avg:  1h 17m | Max:  1h 25m | Hits:  72%/4176  
      🟩 NVHPC              Pass: 100%/2   | Total:  2h 35m | Avg:  1h 17m | Max:  1h 24m | Hits:  67%/2260  
    🟩 gpu
      🟩 h100               Pass: 100%/3   | Total:  1h 11m | Avg: 23m 57s | Max: 26m 03s | Hits:  88%/3669  
      🟩 rtx2080            Pass: 100%/34  | Total:  1d 13h | Avg:  1h 06m | Max:  1h 25m | Hits:  68%/40364 
      🟩 rtxa6000           Pass: 100%/8   | Total:  4h 21m | Avg: 32m 41s | Max:  1h 08m | Hits:  91%/9784  
    🟩 jobs
      🟩 Build              Pass: 100%/37  | Total:  1d 16h | Avg:  1h 05m | Max:  1h 25m | Hits:  68%/44033 
      🟩 DeviceLaunch       Pass: 100%/1   | Total: 23m 41s | Avg: 23m 41s | Max: 23m 41s | Hits:  99%/1223  
      🟩 GraphCapture       Pass: 100%/1   | Total: 18m 11s | Avg: 18m 11s | Max: 18m 11s | Hits:  99%/1223  
      🟩 HostLaunch         Pass: 100%/3   | Total:  1h 11m | Avg: 23m 51s | Max: 24m 45s | Hits:  99%/3669  
      🟩 TestGPU            Pass: 100%/3   | Total:  1h 06m | Avg: 22m 09s | Max: 23m 51s | Hits:  99%/3669  
    🟩 sm
      🟩 90                 Pass: 100%/3   | Total:  1h 11m | Avg: 23m 57s | Max: 26m 03s | Hits:  88%/3669  
      🟩 90;90a;100         Pass: 100%/1   | Total:  1h 14m | Avg:  1h 14m | Max:  1h 14m | Hits:  67%/1223  
    🟩 std
      🟩 17                 Pass: 100%/20  | Total: 22h 06m | Avg:  1h 06m | Max:  1h 24m | Hits:  68%/23677 
      🟩 20                 Pass: 100%/25  | Total: 21h 02m | Avg: 50m 30s | Max:  1h 25m | Hits:  78%/30140 
    
  • 🟩 thrust: Pass: 100%/45 | Total: 22h 36m | Avg: 30m 08s | Max: 55m 40s | Hits: 82%/80271

    🟩 cmake_options
      🟩 -DTHRUST_DISPATCH_TYPE=Force32bit Pass: 100%/2   | Total: 38m 54s | Avg: 19m 27s | Max: 27m 10s | Hits:  89%/3570  
    🟩 cpu
      🟩 amd64              Pass: 100%/43  | Total: 21h 40m | Avg: 30m 15s | Max: 55m 40s | Hits:  82%/76702 
      🟩 arm64              Pass: 100%/2   | Total: 55m 38s | Avg: 27m 49s | Max: 29m 15s | Hits:  79%/3569  
    🟩 ctk
      🟩 12.0               Pass: 100%/5   | Total:  2h 55m | Avg: 35m 02s | Max: 55m 35s | Hits:  78%/8916  
      🟩 12.6               Pass: 100%/2   | Total:  1h 39m | Avg: 49m 58s | Max: 51m 09s | Hits:  74%/3568  
      🟩 12.8               Pass: 100%/38  | Total: 18h 01m | Avg: 28m 27s | Max: 55m 40s | Hits:  82%/67787 
    🟩 cudacxx
      🟩 ClangCUDA18        Pass: 100%/2   | Total: 51m 18s | Avg: 25m 39s | Max: 26m 06s | Hits:  79%/3568  
      🟩 nvcc12.0           Pass: 100%/5   | Total:  2h 55m | Avg: 35m 02s | Max: 55m 35s | Hits:  78%/8916  
      🟩 nvcc12.6           Pass: 100%/2   | Total:  1h 39m | Avg: 49m 58s | Max: 51m 09s | Hits:  74%/3568  
      🟩 nvcc12.8           Pass: 100%/36  | Total: 17h 10m | Avg: 28m 36s | Max: 55m 40s | Hits:  83%/64219 
    🟩 cudacxx_family
      🟩 ClangCUDA          Pass: 100%/2   | Total: 51m 18s | Avg: 25m 39s | Max: 26m 06s | Hits:  79%/3568  
      🟩 nvcc               Pass: 100%/43  | Total: 21h 45m | Avg: 30m 21s | Max: 55m 40s | Hits:  82%/76703 
    🟩 cxx
      🟩 Clang14            Pass: 100%/4   | Total:  1h 54m | Avg: 28m 34s | Max: 29m 34s | Hits:  79%/7136  
      🟩 Clang15            Pass: 100%/2   | Total:  1h 00m | Avg: 30m 03s | Max: 31m 39s | Hits:  79%/3568  
      🟩 Clang16            Pass: 100%/2   | Total:  1h 01m | Avg: 30m 34s | Max: 32m 01s | Hits:  79%/3568  
      🟩 Clang17            Pass: 100%/2   | Total: 58m 11s | Avg: 29m 05s | Max: 29m 48s | Hits:  79%/3568  
      🟩 Clang18            Pass: 100%/7   | Total:  2h 34m | Avg: 22m 08s | Max: 30m 45s | Hits:  85%/12488 
      🟩 GCC7               Pass: 100%/2   | Total:  1h 01m | Avg: 30m 31s | Max: 31m 13s | Hits:  79%/3570  
      🟩 GCC8               Pass: 100%/1   | Total: 31m 53s | Avg: 31m 53s | Max: 31m 53s | Hits:  79%/1785  
      🟩 GCC9               Pass: 100%/2   | Total:  1h 02m | Avg: 31m 07s | Max: 31m 16s | Hits:  79%/3570  
      🟩 GCC10              Pass: 100%/2   | Total:  1h 02m | Avg: 31m 29s | Max: 33m 18s | Hits:  79%/3570  
      🟩 GCC11              Pass: 100%/2   | Total:  1h 01m | Avg: 30m 55s | Max: 32m 41s | Hits:  79%/3570  
      🟩 GCC12              Pass: 100%/2   | Total:  1h 03m | Avg: 31m 31s | Max: 32m 57s | Hits:  79%/3570  
      🟩 GCC13              Pass: 100%/10  | Total:  3h 37m | Avg: 21m 42s | Max: 33m 21s | Hits:  87%/17850 
      🟩 MSVC14.29          Pass: 100%/2   | Total:  1h 51m | Avg: 55m 37s | Max: 55m 40s | Hits:  74%/3556  
      🟩 MSVC14.42          Pass: 100%/3   | Total:  2h 16m | Avg: 45m 32s | Max: 53m 38s | Hits:  82%/5334  
      🟩 NVHPC25.1          Pass: 100%/2   | Total:  1h 39m | Avg: 49m 58s | Max: 51m 09s | Hits:  74%/3568  
    🟩 cxx_family
      🟩 Clang              Pass: 100%/17  | Total:  7h 28m | Avg: 26m 23s | Max: 32m 01s | Hits:  81%/30328 
      🟩 GCC                Pass: 100%/21  | Total:  9h 20m | Avg: 26m 40s | Max: 33m 21s | Hits:  83%/37485 
      🟩 MSVC               Pass: 100%/5   | Total:  4h 07m | Avg: 49m 34s | Max: 55m 40s | Hits:  79%/8890  
      🟩 NVHPC              Pass: 100%/2   | Total:  1h 39m | Avg: 49m 58s | Max: 51m 09s | Hits:  74%/3568  
    🟩 gpu
      🟩 h100               Pass: 100%/2   | Total: 30m 46s | Avg: 15m 23s | Max: 18m 53s | Hits:  89%/3570  
      🟩 rtx2080            Pass: 100%/33  | Total: 18h 21m | Avg: 33m 23s | Max: 55m 40s | Hits:  78%/58868 
      🟩 rtx4090            Pass: 100%/10  | Total:  3h 43m | Avg: 22m 23s | Max: 53m 16s | Hits:  91%/17833 
    🟩 jobs
      🟩 Build              Pass: 100%/38  | Total: 21h 05m | Avg: 33m 17s | Max: 55m 40s | Hits:  78%/67785 
      🟩 TestCPU            Pass: 100%/3   | Total: 45m 40s | Avg: 15m 13s | Max: 29m 42s | Hits:  99%/5347  
      🟩 TestGPU            Pass: 100%/4   | Total: 45m 51s | Avg: 11m 27s | Max: 11m 53s | Hits:  99%/7139  
    🟩 sm
      🟩 90                 Pass: 100%/2   | Total: 30m 46s | Avg: 15m 23s | Max: 18m 53s | Hits:  89%/3570  
      🟩 90;90a;100         Pass: 100%/1   | Total: 31m 38s | Avg: 31m 38s | Max: 31m 38s | Hits:  79%/1785  
    🟩 std
      🟩 17                 Pass: 100%/20  | Total: 11h 48m | Avg: 35m 26s | Max: 55m 40s | Hits:  78%/35671 
      🟩 20                 Pass: 100%/23  | Total: 10h 08m | Avg: 26m 28s | Max: 53m 16s | Hits:  84%/41030 
    
  • 🟩 stdpar: Pass: 100%/4 | Total: 19m 12s | Avg: 4m 48s | Max: 5m 41s

    🟩 cpu
      🟩 amd64              Pass: 100%/2   | Total: 11m 07s | Avg:  5m 33s | Max:  5m 41s
      🟩 arm64              Pass: 100%/2   | Total:  8m 05s | Avg:  4m 02s | Max:  4m 16s
    🟩 ctk
      🟩 12.6               Pass: 100%/4   | Total: 19m 12s | Avg:  4m 48s | Max:  5m 41s
    🟩 cudacxx
      🟩 nvcc12.6           Pass: 100%/4   | Total: 19m 12s | Avg:  4m 48s | Max:  5m 41s
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/4   | Total: 19m 12s | Avg:  4m 48s | Max:  5m 41s
    🟩 cxx
      🟩 NVHPC25.1          Pass: 100%/4   | Total: 19m 12s | Avg:  4m 48s | Max:  5m 41s
    🟩 cxx_family
      🟩 NVHPC              Pass: 100%/4   | Total: 19m 12s | Avg:  4m 48s | Max:  5m 41s
    🟩 gpu
      🟩 rtx2080            Pass: 100%/4   | Total: 19m 12s | Avg:  4m 48s | Max:  5m 41s
    🟩 jobs
      🟩 Build              Pass: 100%/4   | Total: 19m 12s | Avg:  4m 48s | Max:  5m 41s
    🟩 std
      🟩 17                 Pass: 100%/2   | Total:  9m 42s | Avg:  4m 51s | Max:  5m 26s
      🟩 20                 Pass: 100%/2   | Total:  9m 30s | Avg:  4m 45s | Max:  5m 41s
    
  • 🟩 cccl_c_parallel: Pass: 100%/2 | Total: 18m 16s | Avg: 9m 08s | Max: 15m 48s | Hits: 97%/320

    🟩 cpu
      🟩 amd64              Pass: 100%/2   | Total: 18m 16s | Avg:  9m 08s | Max: 15m 48s | Hits:  97%/320   
    🟩 ctk
      🟩 12.8               Pass: 100%/2   | Total: 18m 16s | Avg:  9m 08s | Max: 15m 48s | Hits:  97%/320   
    🟩 cudacxx
      🟩 nvcc12.8           Pass: 100%/2   | Total: 18m 16s | Avg:  9m 08s | Max: 15m 48s | Hits:  97%/320   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/2   | Total: 18m 16s | Avg:  9m 08s | Max: 15m 48s | Hits:  97%/320   
    🟩 cxx
      🟩 GCC13              Pass: 100%/2   | Total: 18m 16s | Avg:  9m 08s | Max: 15m 48s | Hits:  97%/320   
    🟩 cxx_family
      🟩 GCC                Pass: 100%/2   | Total: 18m 16s | Avg:  9m 08s | Max: 15m 48s | Hits:  97%/320   
    🟩 gpu
      🟩 rtx2080            Pass: 100%/2   | Total: 18m 16s | Avg:  9m 08s | Max: 15m 48s | Hits:  97%/320   
    🟩 jobs
      🟩 Build              Pass: 100%/1   | Total:  2m 28s | Avg:  2m 28s | Max:  2m 28s | Hits:  96%/160   
      🟩 Test               Pass: 100%/1   | Total: 15m 48s | Avg: 15m 48s | Max: 15m 48s | Hits:  98%/160   
    
  • 🟩 python: Pass: 100%/1 | Total: 1h 07m | Avg: 1h 07m | Max: 1h 07m

    🟩 cpu
      🟩 amd64              Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    🟩 ctk
      🟩 12.8               Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    🟩 cudacxx
      🟩 nvcc12.8           Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    🟩 cxx
      🟩 GCC13              Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    🟩 cxx_family
      🟩 GCC                Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    🟩 gpu
      🟩 rtx2080            Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    🟩 jobs
      🟩 Test               Pass: 100%/1   | Total:  1h 07m | Avg:  1h 07m | Max:  1h 07m
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
libcu++
+/- CUB
Thrust
CUDA Experimental
stdpar
python
CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
libcu++
+/- CUB
+/- Thrust
CUDA Experimental
+/- stdpar
+/- python
+/- CCCL C Parallel Library
+/- Catch2Helper

🏃‍ Runner counts (total jobs: 97)

# Runner
68 linux-amd64-cpu16
9 windows-amd64-cpu16
6 linux-arm64-cpu16
6 linux-amd64-gpu-rtxa6000-latest-1
3 linux-amd64-gpu-h100-latest-1
3 linux-amd64-gpu-rtx4090-latest-1
2 linux-amd64-gpu-rtx2080-latest-1

rapids-bot Bot pushed a commit to rapidsai/rapids-cmake that referenced this pull request May 2, 2025
This pins to a commit of CCCL with a fix for NVIDIA/cccl#4054.

Once NVIDIA/cccl#4622 is merged, we can switch back to mainline CCCL.

Authors:
  - Bradley Dice (https://github.com/bdice)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)

URL: #833
@bdice
Copy link
Copy Markdown
Contributor Author

bdice commented May 2, 2025

@wmaxey Could this be included in the next build v3.0.0-rc3?

Comment thread cub/cub/device/dispatch/dispatch_reduce.cuh
@github-project-automation github-project-automation Bot moved this from In Review to In Progress in CCCL May 7, 2025
@bdice bdice requested a review from alliepiper May 7, 2025 20:02
@github-project-automation github-project-automation Bot moved this from In Progress to In Review in CCCL May 7, 2025
@alliepiper alliepiper merged commit 3134516 into NVIDIA:branch/3.0.x May 7, 2025
119 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants