Better motivates cuda::device::is_address_from#5341
Merged
fbusato merged 2 commits intoNVIDIA:mainfrom Jul 23, 2025
Merged
Conversation
Contributor
🟩 CI finished in 1h 07m: Pass: 100%/209 | Total: 1d 13h | Avg: 10m 42s | Max: 1h 02m | Hits: 96%/319261
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| +/- | libcu++ |
| CUB | |
| Thrust | |
| CUDA Experimental | |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| +/- | libcu++ |
| +/- | CUB |
| +/- | Thrust |
| +/- | CUDA Experimental |
| +/- | stdpar |
| +/- | python |
| +/- | CCCL C Parallel Library |
| +/- | Catch2Helper |
🏃 Runner counts (total jobs: 209)
| # | Runner |
|---|---|
| 128 | linux-amd64-cpu16 |
| 23 | windows-amd64-cpu16 |
| 16 | linux-amd64-gpu-l4-latest-1 |
| 12 | linux-arm64-cpu16 |
| 11 | linux-amd64-gpu-rtx2080-latest-1 |
| 10 | linux-amd64-gpu-h100-latest-1 |
| 6 | linux-amd64-gpu-rtxa6000-latest-1 |
| 3 | linux-amd64-gpu-rtx4090-latest-1 |
davebayer
approved these changes
Jul 23, 2025
Contributor
davebayer
left a comment
There was a problem hiding this comment.
Thanks for clearing that up :)
|
|
||
| [[nodiscard]] _CCCL_FORCEINLINE _CCCL_VISIBILITY_HIDDEN _CCCL_DEVICE bool | ||
| is_address_from(address_space __space, const void* __ptr) | ||
| [[nodiscard]] _CCCL_DEVICE_API bool is_address_from(address_space __space, const void* __ptr) |
Contributor
There was a problem hiding this comment.
Suggested change
| [[nodiscard]] _CCCL_DEVICE_API bool is_address_from(address_space __space, const void* __ptr) | |
| [[nodiscard]] _CCCL_DEVICE_API inline bool is_address_from(address_space __space, const void* __ptr) |
bernhardmgruber
approved these changes
Jul 23, 2025
Contributor
Author
|
@davebayer Thanks again for the contribution! I needed to improve the documentation for this function. Its purpose will be clearer in a couple of months, but I can't talk about it publicly yet. :) |
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR better motivates the benefits of
cuda::device::is_address_fromcompared to CUDA C functions.Minors: fixes UB in the example and potential warnings in the code