Skip to content

Add a missing variant header in c/parallel#5680

Merged
caugonnet merged 1 commit intoNVIDIA:mainfrom
caugonnet:c_parallel_add_missing_variant_header
Aug 27, 2025
Merged

Add a missing variant header in c/parallel#5680
caugonnet merged 1 commit intoNVIDIA:mainfrom
caugonnet:c_parallel_add_missing_variant_header

Conversation

@caugonnet
Copy link
Contributor

@caugonnet caugonnet commented Aug 27, 2025

Description

This fixes this compilation error I have with g++15 on my local machine

      In file included from /home/caugonnet/git/caugonnet_cccl/c/parallel/src/util/runtime_policy.cpp:17:
      /home/caugonnet/git/caugonnet_cccl/c/parallel/src/util/../nvrtc/command_list.h:86:34: error: 'variant' in namespace 'std' does not name a template type
         86 | using nvrtc_linkable      = std::variant<nvrtc_ltoir, nvrtc_code>;
            |                                  ^~~~~~~
      /home/caugonnet/git/caugonnet_cccl/c/parallel/src/util/../nvrtc/command_list.h:25:1: note: 'std::variant' is defined in header '<variant>'; this is probably fixable by adding '#include <variant>'
         24 | #include <util/errors.h>
        +++ |+#include <variant>

closes

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@caugonnet caugonnet requested a review from a team as a code owner August 27, 2025 12:38
@caugonnet caugonnet requested a review from griwes August 27, 2025 12:38
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Aug 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-project-automation github-project-automation bot moved this to Todo in CCCL Aug 27, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Aug 27, 2025
@caugonnet
Copy link
Contributor Author

/ok to test d678914

@caugonnet caugonnet enabled auto-merge (squash) August 27, 2025 13:57
@github-actions
Copy link
Contributor

🟩 CI finished in 3h 46m: Pass: 100%/26 | Total: 8h 29m | Avg: 19m 35s | Max: 3h 40m | Hits: 98%/680
  • 🟩 python: Pass: 100%/22 | Total: 3h 56m | Avg: 10m 45s | Max: 20m 42s

    🟩 cpu
      🟩 amd64              Pass: 100%/22  | Total:  3h 56m | Avg: 10m 45s | Max: 20m 42s
    🟩 ctk
      🟩 12.5               Pass: 100%/6   | Total: 45m 44s | Avg:  7m 37s | Max: 14m 37s
      🟩 12.8               Pass: 100%/2   | Total: 40m 25s | Avg: 20m 12s | Max: 20m 42s
      🟩 12.9               Pass: 100%/14  | Total:  2h 30m | Avg: 10m 44s | Max: 19m 57s
    🟩 cudacxx
      🟩 nvcc12.5           Pass: 100%/6   | Total: 45m 44s | Avg:  7m 37s | Max: 14m 37s
      🟩 nvcc12.8           Pass: 100%/2   | Total: 40m 25s | Avg: 20m 12s | Max: 20m 42s
      🟩 nvcc12.9           Pass: 100%/14  | Total:  2h 30m | Avg: 10m 44s | Max: 19m 57s
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/22  | Total:  3h 56m | Avg: 10m 45s | Max: 20m 42s
    🟩 cxx
      🟩 GCC13              Pass: 100%/22  | Total:  3h 56m | Avg: 10m 45s | Max: 20m 42s
    🟩 cxx_family
      🟩 GCC                Pass: 100%/22  | Total:  3h 56m | Avg: 10m 45s | Max: 20m 42s
    🟩 gpu
      🟩 h100               Pass: 100%/4   | Total: 42m 29s | Avg: 10m 37s | Max: 17m 12s
      🟩 l4                 Pass: 100%/18  | Total:  3h 14m | Avg: 10m 47s | Max: 20m 42s
    🟩 jobs
      🟩 Build cuda.cccl    Pass: 100%/2   | Total: 21m 51s | Avg: 10m 55s | Max: 11m 00s
      🟩 Test cuda.cccl.cooperative Pass: 100%/5   | Total:  1h 13m | Avg: 14m 37s | Max: 16m 45s
      🟩 Test cuda.cccl.examples Pass: 100%/5   | Total: 23m 48s | Avg:  4m 45s | Max:  5m 00s
      🟩 Test cuda.cccl.headers Pass: 100%/5   | Total: 20m 29s | Avg:  4m 05s | Max:  4m 23s
      🟩 Test cuda.cccl.parallel Pass: 100%/5   | Total:  1h 37m | Avg: 19m 28s | Max: 20m 42s
    🟩 py_version
      🟩 3.10               Pass: 100%/9   | Total:  1h 37m | Avg: 10m 48s | Max: 20m 42s
      🟩 3.13               Pass: 100%/13  | Total:  2h 19m | Avg: 10m 43s | Max: 19m 48s
    
  • 🟩 cccl_c_parallel: Pass: 100%/4 | Total: 4h 32m | Avg: 1h 08m | Max: 3h 40m | Hits: 98%/680

    🟩 cpu
      🟩 amd64              Pass: 100%/4   | Total:  4h 32m | Avg:  1h 08m | Max:  3h 40m | Hits:  98%/680   
    🟩 ctk
      🟩 12.9               Pass: 100%/4   | Total:  4h 32m | Avg:  1h 08m | Max:  3h 40m | Hits:  98%/680   
    🟩 cudacxx
      🟩 nvcc12.9           Pass: 100%/4   | Total:  4h 32m | Avg:  1h 08m | Max:  3h 40m | Hits:  98%/680   
    🟩 cudacxx_family
      🟩 nvcc               Pass: 100%/4   | Total:  4h 32m | Avg:  1h 08m | Max:  3h 40m | Hits:  98%/680   
    🟩 cxx
      🟩 GCC13              Pass: 100%/4   | Total:  4h 32m | Avg:  1h 08m | Max:  3h 40m | Hits:  98%/680   
    🟩 cxx_family
      🟩 GCC                Pass: 100%/4   | Total:  4h 32m | Avg:  1h 08m | Max:  3h 40m | Hits:  98%/680   
    🟩 gpu
      🟩 h100               Pass: 100%/1   | Total: 23m 28s | Avg: 23m 28s | Max: 23m 28s | Hits:  98%/170   
      🟩 l4                 Pass: 100%/1   | Total: 26m 13s | Avg: 26m 13s | Max: 26m 13s | Hits:  98%/170   
      🟩 rtx2080            Pass: 100%/2   | Total:  3h 42m | Avg:  1h 51m | Max:  3h 40m | Hits:  98%/340   
    🟩 jobs
      🟩 Build              Pass: 100%/1   | Total:  2m 01s | Avg:  2m 01s | Max:  2m 01s | Hits:  98%/170   
      🟩 Test               Pass: 100%/3   | Total:  4h 30m | Avg:  1h 30m | Max:  3h 40m | Hits:  98%/510   
    

👃 Inspect Changes

Modifications in project?

Project
CCCL Infrastructure
CCCL Packaging
libcu++
CUB
Thrust
CUDA Experimental
stdpar
python
+/- CCCL C Parallel Library
Catch2Helper

Modifications in project or dependencies?

Project
CCCL Infrastructure
CCCL Packaging
libcu++
CUB
Thrust
CUDA Experimental
stdpar
+/- python
+/- CCCL C Parallel Library
Catch2Helper

🏃‍ Runner counts (total jobs: 26)

# Runner
17 linux-amd64-gpu-l4-latest-1
5 linux-amd64-gpu-h100-latest-1
3 linux-amd64-cpu16
1 linux-amd64-gpu-rtx2080-latest-1

@caugonnet caugonnet merged commit f70ec76 into NVIDIA:main Aug 27, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Aug 27, 2025
davebayer pushed a commit to davebayer/cccl that referenced this pull request Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants