fix completion signature computation of starts_on, work around gcc9 ICE#5724
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom Sep 1, 2025
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 19e8a10 |
Contributor
🟩 CI finished in 28m 34s: Pass: 100%/32 | Total: 4h 20m | Avg: 8m 08s | Max: 20m 27s | Hits: 83%/15498
|
| Project | |
|---|---|
| CCCL Infrastructure | |
| CCCL Packaging | |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper | |
| NVBench Helper |
Modifications in project or dependencies?
| Project | |
|---|---|
| CCCL Infrastructure | |
| +/- | CCCL Packaging |
| libcu++ | |
| CUB | |
| Thrust | |
| +/- | CUDA Experimental |
| stdpar | |
| python | |
| CCCL C Parallel Library | |
| Catch2Helper | |
| NVBench Helper |
🏃 Runner counts (total jobs: 32)
| # | Runner |
|---|---|
| 17 | linux-amd64-cpu16 |
| 6 | linux-amd64-gpu-rtx2080-latest-1 |
| 4 | linux-arm64-cpu16 |
| 4 | windows-amd64-cpu16 |
| 1 | linux-amd64-gpu-h100-latest-1 |
miscco
approved these changes
Sep 1, 2025
davebayer
pushed a commit
to davebayer/cccl
that referenced
this pull request
Sep 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
the cudax execution library is causing gcc9 to ICE in nightly CI. some implementation details of
cudax::execution::get_completion_signatureswere tripping up gcc9. this pr simplifies the code enough for gcc9 to accept it.investigating this let me to an issue in how the
starts_onsender is computing its completion signatures. this pr addresses that problem as well, which was contributing to the ICE.Checklist