Fix problematic clang attribute namespace#5748
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Sep 3, 2025
Merged
Conversation
Contributor
📖 Doc Preview CI🚀 Preview URL: https://NVIDIA.github.io/cccl/pr-preview/pr-5748/ Preview will be available once GitHub Pages deployment completes. |
miscco
approved these changes
Sep 3, 2025
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 35m: Pass: 100%/223 | Total: 4d 10h | Max: 3h 34m | Hits: 83%/324683See results here. |
miscco
pushed a commit
to miscco/cccl
that referenced
this pull request
Sep 3, 2025
miscco
added a commit
that referenced
this pull request
Sep 4, 2025
) * Fix problematic clang attribute namespace (#5748) * Properly guard ptx includes for when we are in cuda mode (#5749) I have expanded our host-only header tests to also include those headers from `cuda/` that we expect to also work with a host compiler Fixes #5747 --------- Co-authored-by: David Bayer <48736217+davebayer@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes nvbug 5498112.
nvcc doesn't recognize
_Clang::as a known attribute namespace. So let's useclang::instead and addclangto pushed/poped macros.