Port thrust::generate[_n] to cub::DeviceTransform::Fill#5807
Merged
bernhardmgruber merged 4 commits intoNVIDIA:mainfrom Sep 9, 2025
Merged
Port thrust::generate[_n] to cub::DeviceTransform::Fill#5807bernhardmgruber merged 4 commits intoNVIDIA:mainfrom
bernhardmgruber merged 4 commits intoNVIDIA:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
dcce549 to
ba16edd
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 22m: Pass: 100%/154 | Total: 5d 18h | Max: 3h 20m | Hits: 76%/177577See results here. |
miscco
approved these changes
Sep 9, 2025
NaderAlAwar
approved these changes
Sep 9, 2025
Comment on lines
+1
to
+2
| // SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | ||
| // SPDX-License-Identifier: BSD-3-Clause |
Contributor
There was a problem hiding this comment.
Question: should this be Apache-2.0 WITH LLVM-exception like the other file? Or did we use BSD here because this is an existing file?
Contributor
Author
There was a problem hiding this comment.
Hmm. I think I modified the file hard enough to justify updating the copyright year, but changing the license feels a bit too much. I know new files should be Apache. Let's stay with the current license.
bernhardmgruber
commented
Sep 15, 2025
Comment on lines
+46
to
+47
| throw_on_error(status, "generate_n: failed inside CUB"); | ||
| return result + count;), |
Contributor
Author
There was a problem hiding this comment.
Critical: This is missing a stream synchronization here. Fixed in #5889
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #5806
Benchmark on RTX 5090 (INCLUDING FIX FROM #5889, re-benchmarked retroactively)