make the concepts portability macros slightly more maintainable#5817
Merged
ericniebler merged 5 commits intoNVIDIA:mainfrom Sep 10, 2025
Merged
make the concepts portability macros slightly more maintainable#5817ericniebler merged 5 commits intoNVIDIA:mainfrom
ericniebler merged 5 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 6cc8ef4 |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test 6cc8ef4 |
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Sep 9, 2025
| #define _CCCL_CONCEPT_REQUIREMENT_SWITCH_typename _CCCL_PP_CASE(TYPENAME) | ||
| #define _CCCL_CONCEPT_REQUIREMENT_SWITCH__Same_as _CCCL_PP_CASE(SAME_AS) | ||
|
|
||
| // Converts "requires(ARGS...)" to "ARGS..." |
ericniebler
force-pushed
the
concept-macro-simplification
branch
from
0d3c077 to
9b82d35
Compare
Contributor
Author
|
/ok to test 9874cfc |
This comment has been minimized.
This comment has been minimized.
ericniebler
force-pushed
the
concept-macro-simplification
branch
from
9874cfc to
de70304
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ericniebler
force-pushed
the
concept-macro-simplification
branch
from
14699e7 to
eaa353b
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 44m: Pass: 100%/229 | Total: 8d 00h | Max: 3h 35m | Hits: 55%/348748See results here. |
davebayer
reviewed
Sep 10, 2025
libcudacxx/test/libcudacxx/std/containers/views/mdspan/layout_stride/comparison.pass.cpp
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
even i have a hard time maintaining the concepts portability macros, and i wrote them. #5794 forced me to grok the macros again, and i decided to record that knowledge in code comments.
i also found a few ways to make the macros themselves (hopefully) easier to grok.
Checklist