Support fancy iterators in vectorized transform and port thrust::tabulate to it#6012
Merged
bernhardmgruber merged 9 commits intoNVIDIA:mainfrom Sep 30, 2025
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
bernhardmgruber
force-pushed
the
fancy_transform
branch
from
2208f23 to
d69fd95
Compare
miscco
reviewed
Sep 26, 2025
Comment on lines
+377
to
+380
| (int{sizeof(it_value_t<RandomAccessIteratorsIn>)} | ||
| * THRUST_NS_QUALIFIER::is_contiguous_iterator_v<RandomAccessIteratorsIn>) ..., | ||
| int{size_of<it_value_t<RandomAccessIteratorOut>>}); |
Contributor
There was a problem hiding this comment.
🙀 I believe those warrant a slightly more elaborate comment
Contributor
Author
There was a problem hiding this comment.
I think this needs a bigger refactoring in general
bernhardmgruber
force-pushed
the
fancy_transform
branch
2 times, most recently
from
3a9e091 to
512baf5
Compare
NaderAlAwar
reviewed
Sep 26, 2025
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
force-pushed
the
fancy_transform
branch
from
81f3ede to
8d22b69
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
changed the title
miscco
approved these changes
Sep 29, 2025
Comment on lines
+249
to
+252
| constexpr int element_size = int{first_nonzero_value( | ||
| (sizeof(it_value_t<RandomAccessIteratorsIn>) | ||
| * THRUST_NS_QUALIFIER::is_contiguous_iterator_v<RandomAccessIteratorsIn>) ..., | ||
| size_of<output_t>)}; |
Contributor
There was a problem hiding this comment.
We should really pull that out into a function
Contributor
Author
There was a problem hiding this comment.
I am strongly considering to refactor the entire mess, so let's postpone any small fixes for now.
Comment on lines
+365
to
+368
| static constexpr bool can_memcpy_contiguous_inputs = | ||
| ((!THRUST_NS_QUALIFIER::is_contiguous_iterator_v<RandomAccessIteratorsIn> | ||
| || THRUST_NS_QUALIFIER::is_trivially_relocatable_v<it_value_t<RandomAccessIteratorsIn>>) | ||
| && ...); |
Contributor
There was a problem hiding this comment.
We should have a trait for that, I guess it will come up more often
bernhardmgruber
force-pushed
the
fancy_transform
branch
from
8d22b69 to
c2cb534
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 48m: Pass: 100%/185 | Total: 8d 00h | Max: 3h 34m | Hits: 18%/189478See results here. |
NaderAlAwar
approved these changes
Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thrust::sequenceandthrust::tabulatebefore and after:B200
Fixes: #5808