Split up high-mem compilations in CUB to help out CI runners#6044
Merged
alliepiper merged 2 commits intoNVIDIA:mainfrom Sep 27, 2025
Merged
Split up high-mem compilations in CUB to help out CI runners#6044alliepiper merged 2 commits intoNVIDIA:mainfrom
alliepiper merged 2 commits intoNVIDIA:mainfrom
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
alliepiper
force-pushed
the
more_cub_timeouts
branch
from
74294a4 to
422014e
Compare
Contributor
Author
|
/ok to test |
alliepiper
force-pushed
the
more_cub_timeouts
branch
from
422014e to
0e1e76f
Compare
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
alliepiper
force-pushed
the
more_cub_timeouts
branch
from
0e1e76f to
67c3c6d
Compare
Contributor
Author
|
/ok to test |
alliepiper
force-pushed
the
more_cub_timeouts
branch
from
67c3c6d to
a2eb54d
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
/ok to test |
This comment has been minimized.
This comment has been minimized.
alliepiper
force-pushed
the
more_cub_timeouts
branch
from
a2eb54d to
44f7bea
Compare
alliepiper
changed the title
These require > 4GB RAM to compile and are causing OOM failures on CI.
alliepiper
force-pushed
the
more_cub_timeouts
branch
from
44f7bea to
3cd4261
Compare
fbusato
reviewed
Sep 26, 2025
Contributor
fbusato
left a comment
fbusato
left a comment
There was a problem hiding this comment.
for_each_in_extents is fine
fbusato
approved these changes
Sep 26, 2025
Contributor
fbusato
left a comment
fbusato
left a comment
There was a problem hiding this comment.
it took me a while to understand what code has been moved, but looks good!
| @@ -0,0 +1,164 @@ | |||
| // SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | |||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | |||
Contributor
There was a problem hiding this comment.
Important: Previously, the code was licensed under BSD-3. I don't think we should change that when moving it to a new file.
Comment on lines
+1
to
+2
| // SPDX-FileCopyrightText: Copyright (c) 2025, NVIDIA CORPORATION. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception |
Contributor
There was a problem hiding this comment.
Same here, code was BSD-3 before
Contributor
🥳 CI Workflow Results🟩 Finished in 5h 36m: Pass: 100%/185 | Total: 2d 09h | Max: 1h 22m | Hits: 98%/184109See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These tests were consuming >4GB RAM during compilatiion. Splitting them up seems to help the random runner failures we've been seeing.