Fix iter_move constraints for MSVC#6357
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Oct 30, 2025
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
9157f1d to
179d304
Compare
This comment has been minimized.
This comment has been minimized.
bernhardmgruber
approved these changes
Oct 28, 2025
This comment has been minimized.
This comment has been minimized.
8951c45 to
836a561
Compare
Contributor
|
@miscco the tests passed with the override of the CI matrix, so I re-enabled the full CI. |
2 tasks
davebayer
approved these changes
Oct 29, 2025
Contributor
|
I see some test failures around a change of |
This comment has been minimized.
This comment has been minimized.
754f5f8 to
be5880a
Compare
This comment has been minimized.
This comment has been minimized.
be5880a to
217e362
Compare
Contributor
Author
Unfortuntely GCC prior to GCC14 is unable to use |
217e362 to
1f8cd11
Compare
This comment has been minimized.
This comment has been minimized.
785a96d to
a68ffe3
Compare
This comment has been minimized.
This comment has been minimized.
a68ffe3 to
64ba2c0
Compare
64ba2c0 to
34f8b35
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 51m: Pass: 100%/89 | Total: 2d 10h | Max: 1h 45m | Hits: 59%/213485See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like we have issues in cases where the iterator prooduces a PR value that does not bind to an lvalue reference.
Investigate workarounds for this