Skip to content

Fix iter_move constraints for MSVC#6357

Merged
davebayer merged 1 commit intoNVIDIA:mainfrom
miscco:fix_iter_move_prvalue
Oct 30, 2025
Merged

Fix iter_move constraints for MSVC#6357
davebayer merged 1 commit intoNVIDIA:mainfrom
miscco:fix_iter_move_prvalue

Conversation

@miscco
Copy link
Contributor

@miscco miscco commented Oct 28, 2025

Seems like we have issues in cases where the iterator prooduces a PR value that does not bind to an lvalue reference.

Investigate workarounds for this

@miscco miscco requested review from a team as code owners October 28, 2025 10:15
@miscco miscco requested a review from jrhemstad October 28, 2025 10:15
@github-project-automation github-project-automation bot moved this to Todo in CCCL Oct 28, 2025
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Oct 28, 2025
@github-actions

This comment has been minimized.

@miscco miscco force-pushed the fix_iter_move_prvalue branch from 9157f1d to 179d304 Compare October 28, 2025 12:43
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@bernhardmgruber
Copy link
Contributor

@miscco the tests passed with the override of the CI matrix, so I re-enabled the full CI.

@bernhardmgruber
Copy link
Contributor

I see some test failures around a change of noexcept:

 /home/coder/cccl/libcudacxx/test/libcudacxx/cuda/iterators/permutation_iterator/iter_swap.pass.cpp(41): error: static assertion failed
     static_assert(!noexcept(cuda::std::ranges::iter_swap(iter1, iter2)));
     ^

@github-actions

This comment has been minimized.

@miscco miscco force-pushed the fix_iter_move_prvalue branch 2 times, most recently from 754f5f8 to be5880a Compare October 29, 2025 11:17
@github-actions

This comment has been minimized.

@miscco miscco force-pushed the fix_iter_move_prvalue branch from be5880a to 217e362 Compare October 29, 2025 12:35
@miscco
Copy link
Contributor Author

miscco commented Oct 29, 2025

I see some test failures around a change of noexcept:

 /home/coder/cccl/libcudacxx/test/libcudacxx/cuda/iterators/permutation_iterator/iter_swap.pass.cpp(41): error: static assertion failed
     static_assert(!noexcept(cuda::std::ranges::iter_swap(iter1, iter2)));
     ^

Unfortuntely GCC prior to GCC14 is unable to use noexcept within a requires clause, which is ...

@miscco miscco force-pushed the fix_iter_move_prvalue branch from 217e362 to 1f8cd11 Compare October 29, 2025 15:08
@github-actions

This comment has been minimized.

@miscco miscco force-pushed the fix_iter_move_prvalue branch 2 times, most recently from 785a96d to a68ffe3 Compare October 29, 2025 21:01
@github-actions

This comment has been minimized.

@miscco miscco force-pushed the fix_iter_move_prvalue branch from a68ffe3 to 64ba2c0 Compare October 30, 2025 07:35
@miscco miscco force-pushed the fix_iter_move_prvalue branch from 64ba2c0 to 34f8b35 Compare October 30, 2025 07:36
@github-actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 3h 51m: Pass: 100%/89 | Total: 2d 10h | Max: 1h 45m | Hits: 59%/213485

See results here.

@davebayer davebayer merged commit 510dcc2 into NVIDIA:main Oct 30, 2025
197 of 201 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Oct 30, 2025
@miscco miscco deleted the fix_iter_move_prvalue branch October 30, 2025 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants