[clang-format] WrapNamespaceBodyWithEmptyLines: Never#6439
Merged
bernhardmgruber merged 3 commits intoNVIDIA:mainfrom Nov 3, 2025
Merged
[clang-format] WrapNamespaceBodyWithEmptyLines: Never#6439bernhardmgruber merged 3 commits intoNVIDIA:mainfrom
bernhardmgruber merged 3 commits intoNVIDIA:mainfrom
Conversation
bernhardmgruber
requested review from
elstehle,
fbusato,
pciolkosz and
wmaxey
This comment has been minimized.
This comment has been minimized.
miscco
approved these changes
Nov 3, 2025
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
I see new formatting guidlines I hite approve
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 12m: Pass: 100%/218 | Total: 1d 03h | Max: 45m 50s | Hits: 99%/380297See results here. |
miscco
approved these changes
Nov 3, 2025
shwina
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found this new option in clang-format 19 and would like to enforce it for consistency. See docs here.
I don't mind too much if we choose
NeverorAlways, but it would be good to enforce one style.Neverremoves about 1.5kLOCs,Alwaysadds about 1kLOC, so we are very inconsistent at the moment.The current PR proposed
Never.