Avoid single letter typenames #6474
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bernhardmgruber
approved these changes
Nov 4, 2025
davebayer
approved these changes
Nov 4, 2025
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
We are using `_T`, which is a reserved macro in MSVC We should just use something different like the common `_Tp`
miscco
force-pushed
the
avoid_single_letter_typenames
branch
from
a0b48b3 to
38f68fe
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 51m: Pass: 100%/166 | Total: 6d 10h | Max: 4h 45m | Hits: 84%/287902See results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using
_T, which is a reserved macro in MSVCWe should just use something different like the common
_Tp