Conversation
|
@charan-003 I added a few more tests. |
|
/ok to test ae2c2c7 |
This comment has been minimized.
This comment has been minimized.
|
/ok to test f549d50 |
This comment has been minimized.
This comment has been minimized.
|
/ok to test b0d8c74 |
This comment has been minimized.
This comment has been minimized.
|
/ok to test 9ea6902 |
This comment has been minimized.
This comment has been minimized.
|
@charan-003 I will review this next week. |
bernhardmgruber
left a comment
bernhardmgruber
left a comment
There was a problem hiding this comment.
This is looking good! A few nits, otherwise LGTM!
|
/ok to test 660b6f2 |
|
/ok to test 9f904ea |
|
@bernhardmgruber I was wondering if it's possible to perform CI tests locally without using Docker? |
Sure! CCCL is just an ordinary cmake project so you can: |
This comment has been minimized.
This comment has been minimized.
|
/ok to test a8df5c0 |
|
/ok to test 9a7675d |
This comment has been minimized.
This comment has been minimized.
|
Thank you so much for taking the time to push the fix through! |
|
@dkolsen-pgi please re-review and unblock. Thx! |
| { | ||
| ::cuda::std::exclusive_scan(block_sums.begin(), block_sums.end(), block_sums.begin(), accum_t{}, wrapped_binary_op); | ||
| // For no init inclusive scan: exclusive_scan starting at second element with first element as init | ||
| if (num_threads > 1) |
There was a problem hiding this comment.
You added the assertion as suggested, but forgot to remove this now unnecessary check for num_threads > 1.
There was a problem hiding this comment.
Right, thanks for bringing this up.
|
/ok to test 0b1e611 |
dkolsen-pgi
left a comment
dkolsen-pgi
left a comment
There was a problem hiding this comment.
I only looked at scan.h, not at the tests. That file now looks good.
🥳 CI Workflow Results🟩 Finished in 1h 30m: Pass: 100%/84 | Total: 14h 28m | Max: 42m 40s | Hits: 88%/116157See results here. |
Co-authored-by: Bernhard Manfred Gruber <bernhardmgruber@gmail.com> (cherry picked from commit bb8a5b9)
|
Successfully created backport PR for |
3 participants
using the first element of each block as the init value
closes #6317