Add ptxas local memory usage warnings to cub builds#6838
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Dec 6, 2025
Merged
Add ptxas local memory usage warnings to cub builds#6838davebayer merged 1 commit intoNVIDIA:mainfrom
davebayer merged 1 commit intoNVIDIA:mainfrom
Conversation
davebayer
force-pushed
the
ptxas_warnings_for_cub
branch
from
3055f61 to
1f13fda
Compare
miscco
approved these changes
Dec 2, 2025
miscco
reviewed
Dec 2, 2025
bernhardmgruber
approved these changes
Dec 2, 2025
Contributor
bernhardmgruber
left a comment
bernhardmgruber
left a comment
There was a problem hiding this comment.
Fine for me, but I would like @alliepiper to have the last word on this.
Contributor
Author
|
Okay! And do we want this for Release only or for ReWithDebInfo, too? |
Contributor
Author
|
I see all of these warnings are generated in the CI, maybe we will want to suppress these warnings there and keep them for local builds only |
This comment has been minimized.
This comment has been minimized.
alliepiper
requested changes
Dec 4, 2025
Contributor
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
Left some initial comments inline.
Will these warnings be promoted to errors with our current warming promotion flags?
davebayer
force-pushed
the
ptxas_warnings_for_cub
branch
from
1f13fda to
5e78a2b
Compare
davebayer
force-pushed
the
ptxas_warnings_for_cub
branch
from
5e78a2b to
7369205
Compare
alliepiper
requested changes
Dec 4, 2025
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
ptxas_warnings_for_cub
branch
from
7369205 to
4a0578f
Compare
This comment has been minimized.
This comment has been minimized.
alliepiper
approved these changes
Dec 5, 2025
Contributor
🥳 CI Workflow Results🟩 Finished in 10h 02m: Pass: 100%/270 | Total: 9d 02h | Max: 4h 48m | Hits: 73%/373903See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ptxasprovides some warnings on local memory usage and register spilling to local memory.This PR adds these warnings to cub Release builds. They are not treated as errors.