do not introduce a pack in a structured binding with nvcc#6994
Merged
ericniebler merged 1 commit intoNVIDIA:mainfrom Dec 17, 2025
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 312d006 |
davebayer
approved these changes
Dec 16, 2025
Contributor
🥳 CI Workflow Results🟩 Finished in 51m 04s: Pass: 100%/43 | Total: 4h 10m | Max: 23m 22s | Hits: 96%/19689See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
cudax/__execution/visit.cuhis using P1061, "Structured Bindings can introduce a Pack", whenever the feature is available.however, it fails to account for the fact that P1061 is not available when your CUDA compiler is nvcc.
this pr disables the use of packs in structured bindings when the compiler is nvcc.
Checklist