Add a test for <nv/target> to validate old dialect support.#7241
Merged
Add a test for <nv/target> to validate old dialect support.#7241
Conversation
davebayer
reviewed
Jan 15, 2026
This comment has been minimized.
This comment has been minimized.
miscco
reviewed
Jan 15, 2026
davebayer
approved these changes
Jan 22, 2026
davebayer
reviewed
Jan 22, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
alliepiper
approved these changes
Jan 28, 2026
Contributor
alliepiper
left a comment
alliepiper
left a comment
There was a problem hiding this comment.
Looks good to me with some minor tweaks.
Comment on lines
11
to
14
| set_directory_properties( | ||
| PROPERTIES | ||
| INCLUDE_DIRECTORIES "${libcudacxx_SOURCE_DIR}/include" | ||
| ) |
Contributor
There was a problem hiding this comment.
Heads up that this API is a bit of a footgun and will clobber any existing directories rather than append. Prefer set_property(DIRECTORY APPEND PROPERTY ...) or include_directories(...).
For consistency with the rest of CCCL, can we move this to a target property?
Suggested change
| set_directory_properties( | |
| PROPERTIES | |
| INCLUDE_DIRECTORIES "${libcudacxx_SOURCE_DIR}/include" | |
| ) |
Member
Author
There was a problem hiding this comment.
I was kind of hoping for the clobbering behavior.
| "nvtarget_cpp${dialect}" PROPERTIES | ||
| CXX_STANDARD "${dialect}" | ||
| CXX_STANDARD_REQUIRED ON | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| target_include_directories(nvtarget_cpp${dialect} PRIVATE "${libcudacxx_SOURCE_DIR}/include") |
| "nvtarget_cuda${dialect}" PROPERTIES | ||
| CUDA_STANDARD "${dialect}" | ||
| CUDA_STANDARD_REQUIRED ON | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| ) | |
| ) | |
| target_include_directories(nvtarget_cuda${dialect} PRIVATE "${libcudacxx_SOURCE_DIR}/include") |
Member
Author
|
pre-commit.ci autofix |
Contributor
Member
Author
|
/ok to test b46f4a1 |
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 22h 45m: Pass: 100%/302 | Total: 4d 23h | Max: 5h 12m | Hits: 96%/451557See results here. |
fbusato
pushed a commit
to fbusato/cccl
that referenced
this pull request
Feb 19, 2026
) * Add a test for <nv/target> to validate old dialect support. * Check CMAKE_<LANG>_FEATURES for compatible standards * spelling fixup * Check host compiler compatibility for CUDA as well * Rename target for nvtarget test * [pre-commit.ci] auto code formatting --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #7196
Checklist