Add cuda.compute APIs for upper_bound and lower_bound
#7250
+708
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shwina
force-pushed
the
cuda-compute-upper-lower-bound
branch
from
f811fe7 to
9df692a
Compare
shwina
changed the title
upper_bound and lower_bound
This comment has been minimized.
This comment has been minimized.
shwina
force-pushed
the
cuda-compute-upper-lower-bound
branch
from
9df692a to
8fb23ad
Compare
NaderAlAwar
approved these changes
Jan 21, 2026
Contributor
|
See #7320 for a proper fix to the binary search return type issue. |
This comment has been minimized.
This comment has been minimized.
shwina
force-pushed
the
cuda-compute-upper-lower-bound
branch
from
ead7bd1 to
74d7ae7
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 22m: Pass: 100%/48 | Total: 16h 06m | Max: 55m 36sSee results here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #6688.
This Python part of this PR is pretty standard. However, on the C side, I found the need to extend the binary search APIs to return indices rather than pointers. The
cub::DeviceFind::Lower/UpperBoundAPIs follow C++ standard library semantics, returning an iterator representing the lower/upper bound positions, rather than indices. On the Python side, we want indices instead, similar to the vectorized versionsthrust::lower_boundandthrust::upper_bound.I couldn't make a
TransformOutputIteratorto make this work. I think this is because of an assumption that the output is always a pointer (not an iterator) here.Checklist