Merged
Conversation
bernhardmgruber
approved these changes
Jan 20, 2026
Contributor
|
We should also ask for @wmaxey's opinion. |
davebayer
commented
Jan 20, 2026
Comment on lines
-129
to
-130
| out << fmt::format( | ||
| (size == 128) ? asm_intrinsic_format_128 : asm_intrinsic_format, |
Contributor
Author
There was a problem hiding this comment.
These are not constant expressions, so I need to split it up into 2 calls
miscco
approved these changes
Jan 20, 2026
wmaxey
approved these changes
Jan 20, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 2d 01h: Pass: 100%/250 | Total: 3d 12h | Max: 5h 45m | Hits: 99%/354476See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using it only for atomics codegen in libcu++ and we can just use
std::formatinstead as was suggested in #7298.