Skip to content

Improves error handling in CUB algorithms using thrust::triple_chevron calls#7415

Merged
elstehle merged 1 commit intoNVIDIA:mainfrom
elstehle:enh/triple-chevron-error-handling
Jan 29, 2026
Merged

Improves error handling in CUB algorithms using thrust::triple_chevron calls#7415
elstehle merged 1 commit intoNVIDIA:mainfrom
elstehle:enh/triple-chevron-error-handling

Conversation

@elstehle
Copy link
Contributor

@elstehle elstehle commented Jan 29, 2026

Description

This PR addresses feedback on another PR (see comment), where it's pointed out that:

tripple chevron can return an error that's coming from a launch failure and isn't reported by subsequent keep at last error. I'd suggest to catch it with auto error = CubDebug(THRUST_NS_QUALIFIER::cuda_cub....

Basically, thrust::triple_chevron does a cudaPeekAtLastError, so we can also drop those redundant calls, where applicable.

@elstehle elstehle requested a review from a team as a code owner January 29, 2026 10:00
@github-project-automation github-project-automation bot moved this to Todo in CCCL Jan 29, 2026
@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Jan 29, 2026
@elstehle elstehle enabled auto-merge (squash) January 29, 2026 13:42
@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

🥳 CI Workflow Results

🟩 Finished in 8h 45m: Pass: 100%/99 | Total: 5d 12h | Max: 5h 56m | Hits: 63%/107543

See results here.

@elstehle elstehle merged commit 90c7d61 into NVIDIA:main Jan 29, 2026
230 of 234 checks passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Jan 29, 2026
fbusato pushed a commit to fbusato/cccl that referenced this pull request Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants