Skip to content

Clarify Docker install step for WSL in .devcontainer README#7516

Merged
jrhemstad merged 2 commits intoNVIDIA:mainfrom
acosmicflamingo:docker-wsl-clarification
Feb 6, 2026
Merged

Clarify Docker install step for WSL in .devcontainer README#7516
jrhemstad merged 2 commits intoNVIDIA:mainfrom
acosmicflamingo:docker-wsl-clarification

Conversation

@acosmicflamingo
Copy link
Contributor

@acosmicflamingo acosmicflamingo commented Feb 5, 2026

Description

Addresses #7508.

For WSL users, the .devcontainers' README is written in a way where it sounds like installing the VSCode Remote Development Extension Pack will automatically handle the Docker step, when in fact it will only handle automatically finding an already-installed Docker.

This PR clarifies the wording of the README so it explicitly states that Docker needs to be installed before installing the VSCode Remote Development Extension Pack.

Checklist

  • I am familiar with the Contributing Guidelines.
  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@acosmicflamingo acosmicflamingo requested a review from a team as a code owner February 5, 2026 18:42
@github-project-automation github-project-automation bot moved this to Todo in CCCL Feb 5, 2026
@copy-pr-bot
Copy link
Contributor

copy-pr-bot bot commented Feb 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Feb 5, 2026
@acosmicflamingo acosmicflamingo force-pushed the docker-wsl-clarification branch from 7271574 to 354813a Compare February 6, 2026 04:18
@acosmicflamingo acosmicflamingo force-pushed the docker-wsl-clarification branch from 354813a to abff7a9 Compare February 6, 2026 04:20
@acosmicflamingo
Copy link
Contributor Author

I wonder if it'd also be beneficial to steer WSL users to installing the Ubuntu distro. Based on these docs and the CUDA toolkit download center, it seems like Ubuntu is definitely the way to go.image

Copy link
Collaborator

@jrhemstad jrhemstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for keeping these instructions up to date! I swear when I originally wrote this doc that the Remote Development Extension would install Docker by default, but I see from the latest docs that this isn't the case.

@jrhemstad
Copy link
Collaborator

I wonder if it'd also be beneficial to steer WSL users to installing the Ubuntu distro. Based on these docs and the CUDA toolkit download center, it seems like Ubuntu is definitely the way to go.

It's always a delicate balance between trying to provide complete instructions in our own documentation vs deferring to other more authoritative documentation. As you've seen, the risk is that if we try and provide complete, detailed instructions, it's likely to eventually get stale. I think for this kind of guidance on what distro to select is better left to the docs at https://docs.nvidia.com/cuda/wsl-user-guide/index.html

@jrhemstad jrhemstad merged commit 91bac21 into NVIDIA:main Feb 6, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from In Review to Done in CCCL Feb 6, 2026
@acosmicflamingo
Copy link
Contributor Author

Gotcha; yes I agree. Thanks for the context 😊

@acosmicflamingo acosmicflamingo deleted the docker-wsl-clarification branch February 6, 2026 17:49
fbusato pushed a commit to fbusato/cccl that referenced this pull request Feb 19, 2026
)

* Clarify Docker install step for WSL in .devcontainer README

* Remove even more ambiguity for Windows users
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants