Fixes dereferencing zip_iterator over tuples of length-1 as well as copies from nested zip_iterators using OpenMP/TBB#7882
Open
andrewcorrigan wants to merge 1 commit intoNVIDIA:mainfrom
Open
Conversation
Contributor
Contributor
Author
|
I found one more case to fix, and will add a test case for that. |
andrewcorrigan
changed the title
andrewcorrigan
changed the title
Contributor
Author
Done |
andrewcorrigan
force-pushed
the
main
branch
2 times, most recently
from
0c648ef to
bdb335d
Compare
…opies from nested zip_iterators using OpenMP/TBB - implements is_compatible to verify that the tuple structure matches to fix conversions - TestZipIteratorDereferenceToValue verifies that casting from the result of dereferencing to the corresponding value type works - TestZipIteratorNestedCopy verifies that copying using nested zip_iterators works Fixes NVIDIA#7855
Contributor
Author
|
Ran clang-format and updated |
Contributor
|
Will look at this on friday |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dereferencing zip_iterator over tuples of length-1 as well as copies from nested zip_iterators using OpenMP/TBB
Fixes #7855
is_compatibleto verify that the tuple structure matches to fix conversionsTestZipIteratorDereferenceToValueverifies that casting from the result of dereferencing to the corresponding value type worksTestZipIteratorNestedCopyverifies that copying using nested zip_iterators worksChecklist