Skip to content

removes a few instances of _CCCL_HOST from string_view#7904

Merged
davebayer merged 2 commits intoNVIDIA:mainfrom
andrewcorrigan:merge/issue-7896
Mar 5, 2026
Merged

removes a few instances of _CCCL_HOST from string_view#7904
davebayer merged 2 commits intoNVIDIA:mainfrom
andrewcorrigan:merge/issue-7896

Conversation

@andrewcorrigan
Copy link
Copy Markdown
Contributor

@andrewcorrigan andrewcorrigan commented Mar 5, 2026 •
edited
Loading

Removes a few instances of _CCCL_HOST from string_view that triggered errors using clang

Fixes #7896

Checklist

  • New or existing tests cover these changes.
  • The documentation is up to date with these changes.

@andrewcorrigan andrewcorrigan requested a review from a team as a code owner March 5, 2026 18:07
@andrewcorrigan andrewcorrigan requested a review from griwes March 5, 2026 18:07
@github-project-automation github-project-automation bot moved this to Todo in CCCL Mar 5, 2026
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot bot commented Mar 5, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@davebayer
Copy link
Copy Markdown
Contributor

davebayer commented Mar 5, 2026

/ok to test 26802aa

@davebayer
Copy link
Copy Markdown
Contributor

davebayer commented Mar 5, 2026

pre-commit.ci autofix

@cccl-authenticator-app cccl-authenticator-app bot moved this from Todo to In Review in CCCL Mar 5, 2026
@davebayer
Copy link
Copy Markdown
Contributor

davebayer commented Mar 5, 2026

/ok to test 9ce6462

davebayer
davebayer approved these changes Mar 5, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@davebayer davebayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this :)

@davebayer davebayer enabled auto-merge (squash) March 5, 2026 18:17
@miscco
Copy link
Copy Markdown
Contributor

miscco commented Mar 5, 2026

Thanks a lot @andrewcorrigan

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 5, 2026

🥳 CI Workflow Results

🟩 Finished in 1h 24m: Pass: 100%/99 | Total: 1d 22h | Max: 1h 22m | Hits: 87%/255613

See results here.

@davebayer davebayer merged commit 510cc9d into NVIDIA:main Mar 5, 2026
117 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@miscco miscco miscco approved these changes

@davebayer davebayer davebayer approved these changes

@griwes griwes Awaiting requested review from griwes griwes is a code owner automatically assigned from NVIDIA/cccl-libcudacxx-codeowners

Assignees

No one assigned

Labels

None yet

Projects

CCCL
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG]: including thrust triggers deduction guide errors in cuda/std/string_view using Clang/CUDA

3 participants

@andrewcorrigan @davebayer @miscco