Fix tiny problem sizes for warpspeed scan#7921
Merged
bernhardmgruber merged 3 commits intoNVIDIA:mainfrom Mar 9, 2026
Merged
Conversation
bernhardmgruber
commented
Mar 6, 2026
| constexpr ::cuda::std::uint16_t byteMask = 0xFFFF; | ||
| const ::cuda::std::uint16_t byteMaskStart = byteMask << cpAsyncOobInfo.smemStartSkipBytes; | ||
| const ::cuda::std::uint16_t byteMaskEnd = byteMask >> (16 - cpAsyncOobInfo.smemEndBytesAfter16BBoundary); | ||
| const ::cuda::std::uint16_t byteMaskEnd = byteMask >> (16 - cpAsyncOobInfo.smemEndBytesAfter16BBoundary) % 16; |
Contributor
Author
There was a problem hiding this comment.
@ahendriksen is there any smarter way to shift byteMask by smemEndBytesAfter16BBoundary, but leave it when it's 16? Would a predicated shift be faster?
Contributor
There was a problem hiding this comment.
Can't think of a quicker way off the top of my head. I always hoped that the compiler would figure out the best way to compute all these values.
A modulo 16 operation is just and AND by ~0xF, which should be quicker than computing the predicate.
Contributor
Author
There was a problem hiding this comment.
Alright, thx!
Contributor
🥳 CI Workflow Results🟩 Finished in 3h 52m: Pass: 100%/249 | Total: 9d 03h | Max: 3h 51m | Hits: 71%/155156See results here. |
miscco
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #7821