Add support for small, variable-size segments to DeviceBatchedTopK#7926
Merged
elstehle merged 9 commits intoNVIDIA:mainfrom Mar 10, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 35m: Pass: 100%/249 | Total: 2d 20h | Max: 1h 34m | Hits: 98%/155652See results here. |
miscco
approved these changes
Mar 9, 2026
Contributor
miscco
left a comment
miscco
left a comment
There was a problem hiding this comment.
Product changes look good
andralex
pushed a commit
to caugonnet/cccl
that referenced
this pull request
Mar 10, 2026
…VIDIA#7926) * prepare tests for var segments * adds tests for small variable-size segments * restores tests for types * reverts now-superfluous segment fixup test code * variable segment size tests * split up test tus, restore utils * adds tests for variable-size keys * fixes tu splitup * style fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7839.
The PR is mostly concerned with extending tests for variable-size segments and secondarily lifting a few prior restrictions and guards for fixed-size segments.