Merged
Conversation
Contributor
Author
|
With the changes in this PR, I can start a tuning run for the warpspeed scan: |
This comment has been minimized.
This comment has been minimized.
9df3030 to
ad0d1ee
Compare
* Duplicate exclusive/sum benchmark for warpspeed since it is too different from the old implementation * Hardcode benchmark OffsetT to uint64 * Review warpspeed scan tuning parameters and expose the relevant ones Fixes: NVIDIA#7893 Fixes: NVIDIA#7894
ad0d1ee to
2dee3c4
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 31m: Pass: 100%/249 | Total: 8d 17h | Max: 2h 30m | Hits: 72%/157696See results here. |
fbusato
approved these changes
Mar 12, 2026
davebayer
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR will create a conflict with #7565 and I am fine with merging this PR after it. This PR is needed to unblock @gonidelis tuning the new scan implementation.
Fixes: #7893
Fixes: #7894