Deprecate cuda::std::rel_ops in c++20#8029
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Mar 15, 2026
Merged
Conversation
davebayer
force-pushed
the
deprecate_rel_ops
branch
from
743ced1 to
72a0473
Compare
davebayer
commented
Mar 13, 2026
Comment on lines
-53
to
-69
| #if _LIBCUDACXX_HAS_SPACESHIP_OPERATOR() | ||
| [[nodiscard]] _CCCL_API constexpr auto operator<=>(completion_behavior __a, completion_behavior __b) noexcept | ||
| -> ::cuda::std::strong_ordering | ||
| { | ||
| return static_cast<int>(__a) <=> static_cast<int>(__b); | ||
| } | ||
| #else | ||
| [[nodiscard]] _CCCL_API constexpr auto operator<(completion_behavior __a, completion_behavior __b) noexcept -> bool | ||
| { | ||
| return static_cast<int>(__a) < static_cast<int>(__b); | ||
| } | ||
| [[nodiscard]] _CCCL_API constexpr auto operator==(completion_behavior __a, completion_behavior __b) noexcept -> bool | ||
| { | ||
| return static_cast<int>(__a) == static_cast<int>(__b); | ||
| } | ||
| using namespace ::cuda::std::rel_ops; | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
As we found out with @bernhardmgruber, enum class is comparable by default
miscco
approved these changes
Mar 13, 2026
bernhardmgruber
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I accidently came across this