Add env DeviceMergeSort::*Copy() overloads#8056
Open
gonidelis wants to merge 1 commit intoNVIDIA:mainfrom
Open
Add env DeviceMergeSort::*Copy() overloads#8056gonidelis wants to merge 1 commit intoNVIDIA:mainfrom
gonidelis wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
gonidelis
force-pushed
the
merge_sort_copy_env
branch
from
c70cd14 to
6f1ef77
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 12m: Pass: 100%/249 | Total: 3d 12h | Max: 52m 19s | Hits: 95%/158752See results here. |
Comment on lines
+123
to
+127
| thrust::device_vector<int> expected_keys{0, 3, 5, 6, 7, 8, 9}; | ||
| // example-end sort-pairs-copy-env | ||
|
|
||
| REQUIRE(error == cudaSuccess); | ||
| REQUIRE(d_keys_out == expected_keys); |
Contributor
There was a problem hiding this comment.
Important: Please also verify d_values_out which have a deterministic value here.
Comment on lines
+106
to
+107
| c2h::device_vector<int> expected_keys{0, 3, 5, 6, 7, 8, 9}; | ||
| REQUIRE(d_keys_out == expected_keys); |
Contributor
There was a problem hiding this comment.
Important: Please also verify the values here. There are no equivalent keys, so the values have a fixed outcome.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #7997