[CUB]: Provide workaround to compilation errors in ptx-json with older nvrtc versions#8139
Merged
NaderAlAwar merged 2 commits intoNVIDIA:mainfrom Mar 24, 2026
Merged
Conversation
NaderAlAwar
added
the
pre-commit.ci autofix
pre-commit-ci
bot
removed
the
pre-commit.ci autofix
Contributor
Contributor
Author
|
/ok to test 2db1b70 |
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 45m: Pass: 100%/249 | Total: 4d 18h | Max: 1h 25m | Hits: 85%/159565See results here. |
miscco
approved these changes
Mar 23, 2026
Comment on lines
+30
to
+35
| #if _CCCL_COMPILER(NVRTC, <, 12, 5) | ||
| template <auto Nested> | ||
| requires a_value<decltype(Nested)> | ||
| #else | ||
| template <a_value auto Nested> | ||
| #endif |
Contributor
There was a problem hiding this comment.
Nitpick: There is no difference between the two formulations, so maybe lets just do
Suggested change
| #if _CCCL_COMPILER(NVRTC, <, 12, 5) | |
| template <auto Nested> | |
| requires a_value<decltype(Nested)> | |
| #else | |
| template <a_value auto Nested> | |
| #endif | |
| template <auto Nested> | |
| requires a_value<decltype(Nested)> |
Contributor
There was a problem hiding this comment.
I don't mind too much, since it's dead code anyway. When the tuning API rollout completes, this code is gone.
bernhardmgruber
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #8138
Checklist