Fix cuda::constant_iterator return value#8260
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Apr 1, 2026
Merged
Conversation
We incorrectly returned `const _Tp&` from `operator*` and `operator[]` This can lead to dangling references in pretty common code, such as `cuda::std::reverse_iterator` which does a `return *::cuda::std::prev(__current_);` The temporary created by `::cuda::std::prev(__current_)` is then dangling because we returned a reference to the value stored in the temporary iterator
davebayer
approved these changes
Apr 1, 2026
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 32m: Pass: 100%/99 | Total: 1d 13h | Max: 1h 15m | Hits: 92%/258659See results here. |
gonidelis
pushed a commit
to gonidelis/cccl
that referenced
this pull request
Apr 8, 2026
We incorrectly returned `const _Tp&` from `operator*` and `operator[]` This can lead to dangling references in pretty common code, such as `cuda::std::reverse_iterator` which does a `return *::cuda::std::prev(__current_);` The temporary created by `::cuda::std::prev(__current_)` is then dangling because we returned a reference to the value stored in the temporary iterator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We incorrectly returned
const _Tp&fromoperator*andoperator[]This can lead to dangling references in pretty common code, such as
cuda::std::reverse_iteratorwhich does areturn *::cuda::std::prev(__current_);The temporary created by
::cuda::std::prev(__current_)is then dangling because we returned a reference to the value stored in the temporary iteratorFound during investigation of issues in #5649