Open
Conversation
bernhardmgruber
commented
Apr 9, 2026
Comment on lines
+42
to
+62
| def get_jsonlist(self, algname, listname): | ||
| benchmark_bin = os.path.join(".", "bin", algname + ".base") | ||
| if not os.path.exists(benchmark_bin): | ||
| raise Exception(f"Benchmark binary not found: {benchmark_bin}") | ||
| return subprocess.check_output([benchmark_bin, f"--jsonlist-{listname}"]) | ||
|
|
||
| def get_bench(self, algname): | ||
| if algname not in self.bench_cache: | ||
| result = subprocess.check_output( | ||
| [os.path.join(".", "bin", algname + ".base"), "--jsonlist-benches"] | ||
| ) | ||
| result = self.get_jsonlist(algname, "benches") | ||
| self.bench_cache[algname] = json.loads(result) | ||
| return self.bench_cache[algname] | ||
|
|
||
| def get_device(self, algname): | ||
| if algname not in self.device_cache: | ||
| result = subprocess.check_output( | ||
| [os.path.join(".", "bin", algname + ".base"), "--jsonlist-devices"] | ||
| ) | ||
| devices = json.loads(result)["devices"] | ||
|
|
||
| result = self.get_jsonlist(algname, "devices") | ||
| data = json.loads(result) | ||
| if "devices" not in data: | ||
| raise Exception( | ||
| "JSON returned from --jsonlist-devices does not contain 'devices' key" | ||
| ) | ||
| devices = data["devices"] |
Contributor
Author
There was a problem hiding this comment.
Those don't change functionality, but should rather improve diagnostics
miscco
reviewed
Apr 9, 2026
| #endif // !TUNE_BASE | ||
|
|
||
| #ifndef USES_WARPSPEED | ||
| # define USES_WARPSPEED() 0 |
Contributor
There was a problem hiding this comment.
Is that still meant to be here?
Contributor
🥳 CI Workflow Results🟩 Finished in 2h 14m: Pass: 100%/230 | Total: 9d 00h | Max: 2h 13m | Hits: 39%/133926See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some more, hopefully final, fixes to make the warpspeed scan tunable.
With this, i can run now:
in
cccl_meta_bench.logI can see:The compilation failures happen whenever a tuning variant is produced that exceeds 48KiB SMEM for a single stage. Such a tuning is rejected at compile-time.