Refactor and improve extents_as queries#8394
Merged
davebayer merged 1 commit intoNVIDIA:mainfrom Apr 14, 2026
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
improve_extents_queries
branch
from
d222d1f to
799f0c8
Compare
This comment has been minimized.
This comment has been minimized.
pciolkosz
reviewed
Apr 14, 2026
| return ::cuda::__hierarchy_extents_mul(__curr_exts, __next_exts); | ||
| } | ||
| } | ||
| else |
Contributor
There was a problem hiding this comment.
I think we can merge if and else if __curr_exts come from a lambda or a helper
Contributor
Author
There was a problem hiding this comment.
It's not that simple, I'd rather keep it as is if you don't mind
davebayer
force-pushed
the
improve_extents_queries
branch
from
c07ade6 to
00e7171
Compare
This comment has been minimized.
This comment has been minimized.
davebayer
force-pushed
the
improve_extents_queries
branch
from
00e7171 to
7ff509b
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 11m: Pass: 100%/149 | Total: 1d 06h | Max: 45m 51s | Hits: 97%/308759See results here. |
davebayer
changed the title
extents_as queries for extents_as queries
pciolkosz
approved these changes
Apr 14, 2026
This was referenced Apr 15, 2026
jainishmehta
pushed a commit
to jainishmehta/cccl
that referenced
this pull request
Apr 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the
extents_asimplementation and adds additional support forwarp_levelqueries in a hierarchy andcluster_levelqueries in a hierarchy whencluster_levelis not part of the hierarchy. This change allows us to use queries with hierarchy parameter inside groups implementation.Partially implements #8310. 2 more PRs will follow with
indexandrankimplementations.