Use the new tuning API internally for detail::select|three_way_partition::dispatch and DevicePartition#8925
Conversation
This comment has been minimized.
This comment has been minimized.
2202fb7 to
f978ca6
Compare
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughSummary by CodeRabbit
suggestion: WalkthroughThis PR rewires DevicePartition/select dispatch to the new CUDA execution tuning API, replaces manual temp-size/allocation with env-based dispatch and policy_selector functors in benchmarks, updates Thrust partition dispatch to call CUB dispatch helper, and adds tests that validate tuning behavior. ChangesDevicePartition + Benchmarks + Thrust + Tests (single cohort)
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 2e262785-9664-4f8f-b738-a61ffdd14e4e
📒 Files selected for processing (6)
cub/benchmarks/bench/partition/flagged.cucub/benchmarks/bench/partition/if.cucub/benchmarks/bench/partition/three_way.cucub/cub/device/device_partition.cuhcub/test/catch2_test_device_partition_env.cuthrust/thrust/system/cuda/detail/partition.h
b03fd61 to
5d6ec8e
Compare
This comment has been minimized.
This comment has been minimized.
…ion::dispatch and DevicePartition Fixes: NVIDIA#8879 Fixes: NVIDIA#8380
5d6ec8e to
2e36a8b
Compare
This comment has been minimized.
This comment has been minimized.
Co-authored-by: Jacob Faibussowitsch <jacob.fai@gmail.com>
|
/ok to test 88442b0 |
🥳 CI Workflow Results🟩 Finished in 1h 39m: Pass: 100%/340 | Total: 2d 18h | Max: 51m 12s | Hits: 94%/339576See results here. |
cub.bench.partition.three_way.baseon SM75;80;86;90;100cub.bench.partition.if.baseon SM75;80;86;90;100cub.bench.partition.flagged.baseon SM75;80;86;90;100Fixes: #8879
Fixes: #8380