Skip to content

[Tile] Reenable tests that were blocked on format accessing bitfields#8963

Merged
miscco merged 1 commit into
NVIDIA:mainfrom
miscco:tile_format
May 13, 2026
Merged

[Tile] Reenable tests that were blocked on format accessing bitfields#8963
miscco merged 1 commit into
NVIDIA:mainfrom
miscco:tile_format

Conversation

@miscco
Copy link
Copy Markdown
Contributor

@miscco miscco commented May 13, 2026

Tests that do not access the bitfields pass

@miscco miscco requested a review from a team as a code owner May 13, 2026 14:29
@miscco miscco requested a review from pciolkosz May 13, 2026 14:29
@github-project-automation github-project-automation Bot moved this to Todo in CCCL May 13, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL May 13, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 13, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: fbc259b3-eb1e-42eb-b5b9-f6295b25203b

📥 Commits

Reviewing files that changed from the base of the PR and between b46191c and cff1d5e.

📒 Files selected for processing (13)
  • libcudacxx/test/libcudacxx/libcxx/text/format/format.arguments/format.arg/arg_t.compile.pass.cpp
  • libcudacxx/test/libcudacxx/libcxx/text/format/format.arguments/format.arg/determine_arg_t.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.arguments/format.arg.store/make_wformat_args.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.arguments/format.args/ctad.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.arguments/format.args/types.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.error/format.error.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/advance_to.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/begin.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/ctor.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/end.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/next_arg_id.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/types.compile.pass.cpp
💤 Files with no reviewable changes (13)
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/begin.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.arguments/format.args/ctad.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/end.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.error/format.error.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/types.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/advance_to.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/ctor.pass.cpp
  • libcudacxx/test/libcudacxx/libcxx/text/format/format.arguments/format.arg/determine_arg_t.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.arguments/format.args/types.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/check_arg_id.pass.cpp
  • libcudacxx/test/libcudacxx/libcxx/text/format/format.arguments/format.arg/arg_t.compile.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.arguments/format.arg.store/make_wformat_args.pass.cpp
  • libcudacxx/test/libcudacxx/std/text/format/format.formatter/format.parse.ctx/next_arg_id.pass.cpp

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes
    • Removed expected-failure markers from multiple format-related tests for tile code, converting them to normal passes and reflecting improved compatibility and stability in tile code builds.

Walkthrough

Removes top-of-file // XFAIL: enable-tile markers and their “bit field read/write is unsupported in tile code” comments from multiple libcudacxx format tests so they are no longer expected to fail under the enable-tile configuration.

Changes

Format Test Tile Failure Markers Removal

Layer / File(s) Summary
Format argument and argument-storage tile failure removal
libcudacxx/test/.../format.arguments/format.arg/arg_t.compile.pass.cpp, libcudacxx/test/.../format.arguments/format.arg/determine_arg_t.compile.pass.cpp, libcudacxx/test/.../format.arguments/format.arg.store/make_wformat_args.pass.cpp
Removed // XFAIL: enable-tile markers and the adjacent “bit field read/write is unsupported in tile code” expected-error comments from argument type determination and storage tests.
Format arguments container tile failure removal
libcudacxx/test/.../format.arguments/format.args/ctad.compile.pass.cpp, libcudacxx/test/.../format.arguments/format.args/types.compile.pass.cpp
Removed // XFAIL: enable-tile markers from format_args CTAD and types compile-pass tests.
Format parse context tile failure removal
libcudacxx/test/.../format.formatter/format.parse.ctx/{advance_to,begin,check_arg_id,ctor,end,next_arg_id,types.compile}.pass.cpp
Removed // XFAIL: enable-tile markers from seven parse context tests covering parse context state and argument ID handling.
Format error tile failure removal
libcudacxx/test/.../format.error/format.error.pass.cpp
Removed // XFAIL: enable-tile marker from format.error test.
important: All changes are removals of test XFAIL annotations; verify CI/test runs under enable-tile to ensure no regressions.

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 1h 06m: Pass: 100%/68 | Total: 1d 07h | Max: 1h 05m | Hits: 75%/500955

See results here.

@miscco miscco merged commit 3f440b9 into NVIDIA:main May 13, 2026
91 checks passed
@miscco miscco deleted the tile_format branch May 13, 2026 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants