Fix GCC 8/9/10 nightly failures: bit_cast, brace-init, -Wno-gnu-*#9037
Draft
alliepiper wants to merge 3 commits into
Draft
Fix GCC 8/9/10 nightly failures: bit_cast, brace-init, -Wno-gnu-*#9037alliepiper wants to merge 3 commits into
alliepiper wants to merge 3 commits into
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test 1c6c2cf |
miscco
reviewed
May 15, 2026
| { | ||
| #if !_CCCL_COMPILER(GCC, <=, 8) | ||
| #if !_CCCL_COMPILER(GCC, <=, 10) | ||
| static_assert(::cuda::std::default_initializable<_To>, |
Contributor
There was a problem hiding this comment.
wasnt there a PR that changed this to is_constructible
Contributor
Author
This comment has been minimized.
This comment has been minimized.
1c6c2cf to
e91bd7b
Compare
Contributor
Author
|
/ok to test e91bd7b |
Contributor
😬 CI Workflow Results🟥 Finished in 1h 11m: Pass: 54%/42 | Total: 19h 52m | Max: 1h 11m | Hits: 28%/207381See results here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three independent build failures from the 2026-05-15 nightly (run 25900203790).
Changes
libcudacxx
bit_cast.h: GCC 8/9/10 don't register__float128in standard type traits, sodefault_initializable<__float128>fails concept check even though__float128 x;is valid C++. The__builtin_bit_castpath is available from GCC 11+; extend the existing GCC ≤8 workaround to GCC ≤10.CUB
catch2_test_device_reduce_env.cu: GCC 8/9 require an explicit type name when returning an aggregate via braced-init-list. Fix two callsites (nondeterministic_reduce_tuninganddeterministic_reduce_tuning) to use named constructors instead of bare{...}.CMake
CCCLBuildCompilerTargets.cmake:-Wno-gnu-line-markerand-Wno-gnu-zero-variadic-macro-argumentsare silently accepted by GCC < 10 without-Werror, soappend_option_if_availableadds them; but the actual build has-Werroractive and passes these vianvcc -Xcompiler=, where GCC < 10 rejects unknown-Wno-*flags. Guard both flags behindGCC >= 10.Test plan
numeric_limits<__float128>::infinity()precompile — ✅ PASScub.test.device.reduce_env.lid_0build — ✅ PASSNotes
CI is scoped to the affected GCC 8/9/10 toolchains via
workflows.override. The override commit and skip tags must be reset before merging.