[Backport branch/3.4.x] [libcu++] Fix default make_shared_resource construction#9047
Merged
Merged
Conversation
* [libcu++] Test default make_shared_resource construction * [libcu++] Fix default make_shared_resource construction * [libcu++] Fix shared_block_ptr in_place construction ambiguity * Fix clang-format (cherry picked from commit 2a660dc)
2 tasks
Contributor
Contributor
|
RAPIDS will need this bugfix backported to the 3.4 release. RMM tests are blocked without it (cannot construct a shared resource for a type that has no constructor parameters). |
bdice
approved these changes
May 17, 2026
bernhardmgruber
approved these changes
May 18, 2026
Contributor
|
/ok to test e11e8a1 |
3 tasks
Contributor
Author
🥳 CI Workflow Results🟩 Finished in 2h 13m: Pass: 100%/113 | Total: 3d 00h | Max: 2h 12m | Hits: 81%/414385See results here. |
rapids-bot Bot
pushed a commit
to rapidsai/rmm
that referenced
this pull request
May 18, 2026
There is a bug in CCCL's `make_shared_resource<T>()` that doesn't work with types that have no constructor arguments. NVIDIA/cccl#9043 NVIDIA/cccl#9044 fixes it, but we need a workaround to unblock CI until that is backported (NVIDIA/cccl#9047) and rapids-cmake is updated. Authors: - Bradley Dice (https://github.com/bdice) Approvers: - David Wendt (https://github.com/davidwendt) URL: #2406
Member
|
@jrhemstad for vis |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #9044 to
branch/3.4.x.