Update all the things to CTK 13.3.#9143
Merged
Merged
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
Author
|
/ok to test |
1 task
bernhardmgruber
approved these changes
May 27, 2026
This comment has been minimized.
This comment has been minimized.
Looks like there is a miscompilation in 13.3 with the result of the comparison when NaN is involved.
Contributor
|
/ok to test 8a20921 |
miscco
approved these changes
May 28, 2026
This comment has been minimized.
This comment has been minimized.
Contributor
|
/ok to test f08a271 |
This comment has been minimized.
This comment has been minimized.
…13.3 MSVC 14.44/14.50 + nvcc 13.3 incorrectly fires C4189 on constexpr locals used only as non-type template parameters; [[maybe_unused]] suppresses it. Separately, MSVC CTAD synthesis rejects env_t's constructor when the first parameter type is a private typedef; spelling out any_resource<_Properties...> directly avoids the private-name access.
Contributor
Author
|
/ok to test b5644c3 |
This comment has been minimized.
This comment has been minimized.
Contributor
|
pre-commit.ci autofix |
Contributor
Contributor
|
/ok to test 1197d54 |
This comment has been minimized.
This comment has been minimized.
Contributor
Author
|
pre-commit.ci autofix |
Contributor
📝 WalkthroughSummary by CodeRabbit
WalkthroughDevcontainer base image tags ( ChangesDevcontainer Infrastructure Update
Test and Compiler Infrastructure Updates
Suggested labels
Suggested reviewers
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
🥳 CI Workflow Results🟩 Finished in 4h 29m: Pass: 100%/501 | Total: 4d 10h | Max: 59m 01s | Hits: 99%/631536See results here. |
shwina
pushed a commit
to shwina/cccl
that referenced
this pull request
Jun 1, 2026
* Update all the things to CTK 13.3. * [MSVC] Avoid unused variable warning * [libcu++] Disable tests that are technically invalid and are now warned * [libcu++] Disable runtime issue with `in_range` Looks like there is a miscompilation in 13.3 with the result of the comparison when NaN is involved. * [libcu++] Expand workaround for extreme value * Also disable buggy test for nvrtc * [STF] Add missing include * [CUB] More unused variable warnings * [STF] Avoid NVCC compiler bug about dependent base classes * Work around MSVC C4189 false-positives and CTAD regression under CTK 13.3 MSVC 14.44/14.50 + nvcc 13.3 incorrectly fires C4189 on constexpr locals used only as non-type template parameters; [[maybe_unused]] suppresses it. Separately, MSVC CTAD synthesis rejects env_t's constructor when the first parameter type is a private typedef; spelling out any_resource<_Properties...> directly avoids the private-name access. --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mostly devcontainer updates from the version bump.
Waiting for https://github.com/rapidsai/devcontainers/actions/runs/26529587350 to test.