Skip to content

[cub] Fix warp reduce of fixed size random access range#9153

Merged
davebayer merged 1 commit into
NVIDIA:mainfrom
davebayer:fix_cub_warp_reduce
May 29, 2026
Merged

[cub] Fix warp reduce of fixed size random access range#9153
davebayer merged 1 commit into
NVIDIA:mainfrom
davebayer:fix_cub_warp_reduce

Conversation

@davebayer
Copy link
Copy Markdown
Contributor

Came across this one, it tries to call non-existing overload. It should call the overload above I believe

@davebayer davebayer requested a review from a team as a code owner May 28, 2026 07:26
@davebayer davebayer requested a review from pauleonix May 28, 2026 07:26
@github-project-automation github-project-automation Bot moved this to Todo in CCCL May 28, 2026
@cccl-authenticator-app cccl-authenticator-app Bot moved this from Todo to In Review in CCCL May 28, 2026
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 28, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1ff7e571-e9ae-454f-9893-9b3a63282887

📥 Commits

Reviewing files that changed from the base of the PR and between dea0ca3 and 7da7017.

📒 Files selected for processing (1)
  • cub/cub/warp/warp_reduce.cuh

📝 Walkthrough

Summary by CodeRabbit

  • Refactor
    • Optimized internal method invocation in the warp reduction implementation to use a more efficient calling pattern while maintaining API compatibility.

Walkthrough

The range-based WarpReduce::Reduce() overload now calls the correct two-parameter full-warp reduce overload, passing only the thread-local reduction and the operation, instead of incorrectly passing a third LogicalWarpThreads argument.

Changes

WarpReduce range-based reduce API call

Layer / File(s) Summary
WarpReduce reduce overload call fix
cub/cub/warp/warp_reduce.cuh
Range-based WarpReduce::Reduce(const InputType&, ReductionOp) forwards the per-thread reduced value to the two-parameter Reduce(thread_reduction, reduction_op) overload instead of the prior three-parameter call with LogicalWarpThreads.

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

🥳 CI Workflow Results

🟩 Finished in 2h 33m: Pass: 100%/285 | Total: 11d 16h | Max: 2h 32m | Hits: 15%/1135600

See results here.

@davebayer davebayer merged commit ca4c5a6 into NVIDIA:main May 29, 2026
308 of 309 checks passed
@github-project-automation github-project-automation Bot moved this from In Review to Done in CCCL May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Successfully created backport PR for branch/3.3.x:

@github-actions
Copy link
Copy Markdown
Contributor

Successfully created backport PR for branch/3.4.x:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants