[cudax] Define _CUDAX_ENABLE_GROUP_FEATURES_IN_LIBCUDACXX globally in cudax

[davebayer]

No description provided.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5a006d80-8ce2-4f37-bbed-b0de35f873f9

📥 Commits

Reviewing files that changed from the base of the PR and between c5b273b and 5233f2f.

📒 Files selected for processing (4)

• cudax/cmake/cudaxBuildCompilerTargets.cmake
• cudax/test/CMakeLists.txt
• libcudacxx/include/cuda/__hierarchy/hierarchy_level_base.h
• libcudacxx/include/cuda/__hierarchy/native_hierarchy_level_base.h

💤 Files with no reviewable changes (1)

• cudax/test/CMakeLists.txt

✅ Files skipped from review due to trivial changes (2)

• cudax/cmake/cudaxBuildCompilerTargets.cmake
• libcudacxx/include/cuda/__hierarchy/hierarchy_level_base.h

🚧 Files skipped from review as they are similar to previous changes (1)

• libcudacxx/include/cuda/__hierarchy/native_hierarchy_level_base.h

---

📝 Walkthrough

Summary by CodeRabbit

• Refactor
  • Enabled experimental group-related features in the CUDA C++ library build.
• Tests
  • Adjusted test build setup so the group-related build flag is no longer applied on a per-test basis.

suggestion:

Walkthrough

This PR centralizes enabling of experimental "group" code by adding _CUDAX_ENABLE_GROUP_FEATURES_IN_LIBCUDACXX to global compiler definitions and updates hierarchy headers to use that macro instead of the per-target _CUDAX_GROUP definition.

Changes

Group feature gate migration

Layer / File(s)	Summary
Global macro definition and test cleanup cudax/cmake/cudaxBuildCompilerTargets.cmake, cudax/test/CMakeLists.txt	CMake appends _CUDAX_ENABLE_GROUP_FEATURES_IN_LIBCUDACXX to global cxx_compile_definitions; per-test target_compile_definitions(... _CUDAX_GROUP) entries are removed from group test executables.
Header guard migration libcudacxx/include/cuda/__hierarchy/hierarchy_level_base.h, libcudacxx/include/cuda/__hierarchy/native_hierarchy_level_base.h	Preprocessor guards that previously used #if defined(_CUDAX_GROUP) are updated to #if defined(_CUDAX_ENABLE_GROUP_FEATURES_IN_LIBCUDACXX) for group-related includes, APIs, and aliases.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

🧹 Nitpick comments (1)

cudax/cmake/cudaxBuildCompilerTargets.cmake (1)

40-42: ⚡ Quick win

suggestion: Remove duplicate phrase in comment. Line 41-42 contains "to get access to get access to the code" - the phrase "get access to" is repeated.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 0598ad2f-5428-49d7-842e-6e1592bc7746

📥 Commits

Reviewing files that changed from the base of the PR and between d083f97 and 4e9bdbe.

📒 Files selected for processing (4)

• cudax/cmake/cudaxBuildCompilerTargets.cmake
• cudax/test/CMakeLists.txt
• libcudacxx/include/cuda/__hierarchy/hierarchy_level_base.h
• libcudacxx/include/cuda/__hierarchy/native_hierarchy_level_base.h

💤 Files with no reviewable changes (1)

• cudax/test/CMakeLists.txt

[github-actions]

🥳 CI Workflow Results

🟩 Finished in 1h 15m: Pass: 100%/159 | Total: 2d 04h | Max: 1h 15m | Hits: 87%/664974

See results here.