Use the new tuning API internally for detail::find::dispatch#9240
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
OverviewThis PR migrates internal dispatch for DeviceFind::FindIf to use the new tuning API and environment-based dispatching so that tuned policies can be selected and applied from execution environments. No external/public API signatures were changed. What I verified (files inspected)
Changes
Impact / Notes
suggestion: WalkthroughUpdates DeviceFind::FindIf to compute and pass a tuning policy selector at dispatch; adds a test that exercises cuda::execution::tune(...) to enforce block size and verify it was applied; updates benchmark to optionally construct a compile-time policy selector and run under the tuning environment. ChangesTuning API Integration for DeviceFind::FindIf
Assessment against linked issues
Suggested reviewers
Comment |
|
@gonidelis Please still do a SASS check of the find if benchmark! |
This comment has been minimized.
This comment has been minimized.
🥳 CI Workflow Results🟩 Finished in 1h 44m: Pass: 100%/284 | Total: 1d 22h | Max: 53m 27s | Hits: 98%/196763See results here. |
|
No SASS diffs observed for sm120 |
fixes #9237