[Backport 3.4] Backport PSTL fixes#9256
Conversation
…NVIDIA#9216) (cherry picked from commit 2a82ae1)
…lgorithms (NVIDIA#9214) (cherry picked from commit 4f5bc7c)
(cherry picked from commit cfe7e26)
* [libcu++] Use stream's context in PSTL * Address review comments * Actually use the right name * Morning coffee * fixes * fix --------- Co-authored-by: Michael Schellenberger Costa <miscco@nvidia.com> (cherry picked from commit 2f7cb8b)
📝 WalkthroughSummary by CodeRabbitRelease Notes
WalkthroughThis PR introduces ChangesCUDA Context and Stream Management
Possibly related PRs
Suggested labels
Suggested reviewers
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 Infer (1.2.0)libcudacxx/test/libcudacxx/cuda/execution/execution_policy/get_memory_resource.pass.cpplibcudacxx/test/libcudacxx/cuda/execution/execution_policy/get_memory_resource.pass.cpp:17:10: fatal error: 'cuda/functional' file not found ... [truncated 1214 characters] ... l/include" "-internal-isystem" libcudacxx/test/libcudacxx/cuda/execution/execution_policy/get_stream.pass.cpplibcudacxx/test/libcudacxx/cuda/execution/execution_policy/get_stream.pass.cpp:17:10: fatal error: 'cuda/functional' file not found ... [truncated 1187 characters] ... /usr/local/include" "-internal-isystem" Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
libcudacxx/include/cuda/std/__pstl/cuda/ensure_current_context.h (1)
39-41: ⚡ Quick winsuggestion: Fully qualify
get_stream_tandget_streamfrom the global namespace.Line 39 and Line 41 rely on unqualified lookup inside
cuda::std::execution; switch to::cuda::get_stream_tand::cuda::get_streamto match project rules and avoid accidental shadowing.
As per coding guidelines, "All calls to free functions must be fully qualified starting from the global namespace, e.g.,::cuda::ceil_div."
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 94b27f12-f257-407e-a313-1fd766494a86
📒 Files selected for processing (29)
libcudacxx/include/cuda/std/__pstl/cuda/adjacent_difference.hlibcudacxx/include/cuda/std/__pstl/cuda/copy_if.hlibcudacxx/include/cuda/std/__pstl/cuda/copy_n.hlibcudacxx/include/cuda/std/__pstl/cuda/ensure_current_context.hlibcudacxx/include/cuda/std/__pstl/cuda/exclusive_scan.hlibcudacxx/include/cuda/std/__pstl/cuda/find_if.hlibcudacxx/include/cuda/std/__pstl/cuda/for_each_n.hlibcudacxx/include/cuda/std/__pstl/cuda/generate_n.hlibcudacxx/include/cuda/std/__pstl/cuda/inclusive_scan.hlibcudacxx/include/cuda/std/__pstl/cuda/max_element.hlibcudacxx/include/cuda/std/__pstl/cuda/merge.hlibcudacxx/include/cuda/std/__pstl/cuda/min_element.hlibcudacxx/include/cuda/std/__pstl/cuda/partition.hlibcudacxx/include/cuda/std/__pstl/cuda/partition_copy.hlibcudacxx/include/cuda/std/__pstl/cuda/reduce.hlibcudacxx/include/cuda/std/__pstl/cuda/remove_if.hlibcudacxx/include/cuda/std/__pstl/cuda/rotate.hlibcudacxx/include/cuda/std/__pstl/cuda/rotate_copy.hlibcudacxx/include/cuda/std/__pstl/cuda/shift_left.hlibcudacxx/include/cuda/std/__pstl/cuda/shift_right.hlibcudacxx/include/cuda/std/__pstl/cuda/sort.hlibcudacxx/include/cuda/std/__pstl/cuda/stable_partition.hlibcudacxx/include/cuda/std/__pstl/cuda/temporary_storage.hlibcudacxx/include/cuda/std/__pstl/cuda/transform.hlibcudacxx/include/cuda/std/__pstl/cuda/transform_reduce.hlibcudacxx/include/cuda/std/__pstl/cuda/unique.hlibcudacxx/test/libcudacxx/cuda/execution/execution_policy/get_memory_resource.pass.cpplibcudacxx/test/libcudacxx/cuda/execution/execution_policy/get_stream.pass.cpplibcudacxx/test/utils/libcudacxx/test/config.py
🥳 CI Workflow Results🟩 Finished in 1h 28m: Pass: 100%/113 | Total: 2d 02h | Max: 1h 04m | Hits: 75%/439700See results here. |
Batch of PSTL backports to 3.4.x:
-Wattributesin lit tests with nvcc 12.0 and gcc #9216cudaStreamPerThreadwithcudaStream{}in PSTL #9214