-
Notifications
You must be signed in to change notification settings - Fork 35
GPU Operator 25.3.0 release docs #165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Documentation preview |
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
gpu-operator/gpu-operator-rdma.rst
Outdated
| nvidia/gpu-operator \ | ||
| --version=${version} \ | ||
| --set driver.useOpenKernelModules=true \ | ||
| --set driver.kernelModuleType=open \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's be consistent across the two install commands presented here in this section. Either both commands should specify --set driver.kernelModuleType=open or both commands should omit setting this field. I would be in favor of omitting this field as auto should take care of installing the open modules on supported systems. We can highlight that setting driver.kernelModuleType=open is only needed for older driver container versions where auto is not supported -- either in the text below or in a note.
I would be in favor of removing this field altogether since it is optional for users to configure it. The default setting, auto, should be sufficient as called out in the text.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you have already implemented my suggestion in the Installing the GPU Operator and Enabling GPUDirect Storage section :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the sample here to match the sample in the other section!
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
cdesiniotis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-mccarthy I think we are close to proceeding with this PR -- just a few small open items / suggestions to accommodate.
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
gpu-operator/release-notes.rst
Outdated
| Currently, ``auto`` is only supported with the 570.86.15 and 570.124.06 or later driver containers. | ||
| 550 and 535 branch drivers do not yet support this mode. | ||
|
|
||
| In previous versions, the ``useOpenKernelModules`` field specified the driver containers to install the NVIDIA Open GPU Kernel module driver. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| In previous versions, the ``useOpenKernelModules`` field specified the driver containers to install the NVIDIA Open GPU Kernel module driver. | |
| In previous versions, the ``useOpenKernelModules`` field specified the driver containers to install the NVIDIA Open GPU kernel module driver. |
Signed-off-by: Abigail McCarthy <20771501+a-mccarthy@users.noreply.github.com>
cdesiniotis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@a-mccarthy thanks for the work and patience on this one!
No description provided.