Package NVIDIA Container Toolkit install as a reusable Ansible role#147
Open
Hardikrepo wants to merge 2 commits into
Open
Package NVIDIA Container Toolkit install as a reusable Ansible role#147Hardikrepo wants to merge 2 commits into
Hardikrepo wants to merge 2 commits into
Conversation
…ker CE, modern apt keyring, Calico enP* support Resolves NVIDIA#140: replaces deprecated apt_key module with get_url+gpg --dearmor, pins docker-ce to 29.4.3 with arch detection instead of state: latest, switches GPU/Network Operator helm installs from install --generate-name to upgrade --install for retry-safety, and adds enP* to Calico IP_AUTODETECTION_METHOD for GB200/Grace NIC names.
Resolves NVIDIA#74: the toolkit install steps were only available embedded inside playbooks/nvidia-docker.yaml, tightly coupled to Cloud Native Stack's own variables (nvidia_docker_exists, cns_version, etc.), so other NVIDIA customers couldn't reuse just this part. Adds roles/nvidia_container_toolkit/, a self-contained role with: - defaults/main.yml: nvidia_container_toolkit_version, nvidia_container_toolkit_runtime, nvidia_container_toolkit_enable_cdi - tasks/main.yml: apt/yum key + repo setup, pinned package install on Ubuntu/Debian and RHEL/CentOS, and nvidia-ctk CDI configuration for docker, containerd, cri-dockerd, or cri-o - meta/main.yml + README.md documenting standalone usage via `ansible-galaxy role install git+https://github.com/NVIDIA/cloud-native-stack,master#/roles/nvidia_container_toolkit` This is additive only; the existing nvidia-docker.yaml playbook is unchanged and continues to work as before.
a37e691 to
dccf543
Compare
Collaborator
|
Thank you for the contribution. Please fork the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #74.
Summary
The NVIDIA Container Toolkit install steps were only available embedded inside
playbooks/nvidia-docker.yaml, tightly coupled to Cloud Native Stack's own variables (nvidia_docker_exists,cns_version, etc.). As requested in the issue, other NVIDIA customers couldn't reuse just this part without pulling in the whole CNS playbook.Adds
roles/nvidia_container_toolkit/, a self-contained, standalone Ansible role:defaults/main.yml—nvidia_container_toolkit_version,nvidia_container_toolkit_runtime(docker/containerd/cri-dockerd/cri-o),nvidia_container_toolkit_enable_cdi,nvidia_container_toolkit_remove_existingtasks/main.yml— apt/yum signing key + repo setup, pinned package install on Ubuntu/Debian and RHEL/CentOS, andnvidia-ctkCDI configuration for the chosen runtimemeta/main.yml+README.mddocumenting usage via:This is purely additive —
playbooks/nvidia-docker.yamlis unchanged and the existing CNS install flow continues to work exactly as before.Test plan
playbooks/nvidia-docker.yamlfor parity